Skip to content

Comments

SNOW-2866374: Enforce deterministic column ordering in infer_schema#4021

Merged
sfc-gh-mayliu merged 4 commits intomainfrom
SNOW-2866374-deterministic-col-order-infer-schema
Dec 6, 2025
Merged

SNOW-2866374: Enforce deterministic column ordering in infer_schema#4021
sfc-gh-mayliu merged 4 commits intomainfrom
SNOW-2866374-deterministic-col-order-infer-schema

Conversation

@sfc-gh-mayliu
Copy link
Collaborator

@sfc-gh-mayliu sfc-gh-mayliu commented Dec 4, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2866374

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-mayliu sfc-gh-mayliu added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Dec 5, 2025
@sfc-gh-mayliu sfc-gh-mayliu requested a review from a team December 5, 2025 00:22
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor questions.

return (
"""
Note: If ordered is set to True (default), results are ordered by ORDER_ID and
COLUMN_NAME for deterministic column ordering. Set to False to disable ordering.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can call this out as improvement in the changelog

@sfc-gh-mayliu sfc-gh-mayliu removed the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Dec 5, 2025
@sfc-gh-mayliu sfc-gh-mayliu requested a review from a team December 5, 2025 23:43
@sfc-gh-mayliu sfc-gh-mayliu merged commit 2824029 into main Dec 6, 2025
31 of 33 checks passed
@sfc-gh-mayliu sfc-gh-mayliu deleted the SNOW-2866374-deterministic-col-order-infer-schema branch December 6, 2025 00:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants