Skip to content

Commit 1715c9d

Browse files
shuttiebenjben
authored andcommitted
Scala 2.12 support (closes #153)
1 parent 3b86aec commit 1715c9d

File tree

9 files changed

+34
-172
lines changed

9 files changed

+34
-172
lines changed

.travis.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
language: scala
22
before_script: "cd java-scala"
33
scala:
4-
- 2.9.1
4+
- 2.12.4
55
jdk:
6-
- oraclejdk7
7-
- openjdk6
8-
- openjdk7
6+
- oraclejdk8
7+
- openjdk8

java-scala/.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,5 @@ lib_managed/
1010
src_managed/
1111
project/boot/
1212
project/plugins/project/
13+
project/project
14+
project/target

java-scala/build.sbt

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
name := "referer-parser"
2+
organization := "com.snowplowanalytics"
3+
version := "0.3.0"
4+
description := "Library for extracting marketing attribution data from referer URLs"
5+
scalaVersion := "2.12.4"
6+
crossScalaVersions := Seq("2.11.11", "2.12.4")
7+
scalacOptions := Seq("-deprecation", "-encoding", "utf8")
8+
9+
libraryDependencies ++= Seq(
10+
"org.yaml" % "snakeyaml" % "1.19",
11+
"org.apache.httpcomponents" % "httpclient" % "4.5.3",
12+
"org.specs2" %% "specs2" % specsVersion(scalaVersion.value) % "test",
13+
"junit" % "junit" % "4.12" % "test",
14+
"org.json" % "json" % "20170516" % "test",
15+
"org.json4s" %% "json4s-jackson" % "3.5.3" % "test",
16+
"org.json4s" %% "json4s-scalaz" % "3.5.3" % "test"
17+
)
18+
19+
20+
def specsVersion(scalaVer: String) = scalaVer match {
21+
case "2.11.11" => "3.7"
22+
case "2.12.4" => "2.5"
23+
}

java-scala/project/BuildSettings.scala

Lines changed: 0 additions & 48 deletions
This file was deleted.

java-scala/project/Dependencies.scala

Lines changed: 0 additions & 64 deletions
This file was deleted.

java-scala/project/RefererParserBuild.scala

Lines changed: 0 additions & 48 deletions
This file was deleted.

java-scala/project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=0.13.2
1+
sbt.version=1.0.2

java-scala/src/test/scala/com/snowplowanalytics/refererparser/scala/JsonParseTest.scala

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,17 @@ class JsonParseTest extends Specification {
4040

4141
val internalDomains = List("www.subdomain1.snowplowanalytics.com", "www.subdomain2.snowplowanalytics.com")
4242

43-
def getString(node: JValue, name: String): String =
43+
def getString(node: JValue, name: String): String =
4444
(node \ name) match {
4545
case JString(s) => s
4646
case _ => throw new Exception("The value of field '%s' in referer-tests.json is not a string - this should never happen".format(name))
4747
}
4848

4949
"parse" should {
50+
"extract the expected details from referer with spec" in {
51+
for (test <- testJson) yield {
5052

51-
for (test <- testJson) {
52-
53-
"extract the expected details from referer with spec '%s'".format(getString(test, "spec")) in {
54-
55-
Parser.parse(getString(test, "uri"), pageHost, internalDomains) must_==
53+
Parser.parse(getString(test, "uri"), pageHost, internalDomains) shouldEqual
5654
Some(Referer(
5755
Medium.withName(getString(test, "medium")),
5856
(test \ "source") match {

java-scala/src/test/scala/com/snowplowanalytics/refererparser/scala/ParseFuzzTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,5 @@ class ParseFuzzTest extends Specification with ScalaCheck {
3131
"The parse function should work for any pair of referer and page Strings" ! e1
3232

3333
def e1 =
34-
check { (refererUri: String, pageUri: String) => Parser.parse(refererUri, pageUri) must beAnInstanceOf[Parser.MaybeReferer] }
34+
prop { (refererUri: String, pageUri: String) => Parser.parse(refererUri, pageUri) must beAnInstanceOf[Parser.MaybeReferer] }
3535
}

0 commit comments

Comments
 (0)