Skip to content

Commit 7baaa22

Browse files
committed
Now using JavaConversions to convert from Scala List
1 parent f9274fe commit 7baaa22

File tree

1 file changed

+4
-7
lines changed
  • java-scala/src/main/scala/com/snowplowanalytics/refererparser/scala

1 file changed

+4
-7
lines changed

java-scala/src/main/scala/com/snowplowanalytics/refererparser/scala/Parser.scala

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,15 @@
1717
package com.snowplowanalytics.refererparser.scala
1818

1919
// Java
20-
import java.util.{List => JavaList}
2120
import java.net.{URI, URISyntaxException}
2221

2322
// RefererParser Java impl
2423
import com.snowplowanalytics.refererparser.{Parser => JParser}
2524
import com.snowplowanalytics.refererparser.{Medium => JMedium}
2625

26+
// Scala
27+
import scala.collection.JavaConversions._
28+
2729
/**
2830
* Enumeration for supported mediums.
2931
*
@@ -126,12 +128,7 @@ object Parser {
126128
def parse(refererUri: URI, pageHost: String, internalDomains: List[String]): MaybeReferer = {
127129

128130
try {
129-
130-
// Convert from a Scala list to a Java list
131-
val javaInternalDomains = new java.util.ArrayList[String](internalDomains.size)
132-
internalDomains.foreach (javaInternalDomains.add(_))
133-
134-
val jrefr = Option(jp.parse(refererUri, pageHost, javaInternalDomains))
131+
val jrefr = Option(jp.parse(refererUri, pageHost, internalDomains))
135132
jrefr.map(jr =>
136133
Referer(Medium.fromJava(jr.medium), Option(jr.source), Option(jr.term))
137134
)

0 commit comments

Comments
 (0)