@@ -236,8 +236,8 @@ def maxwell_filter(
236236 mag_scale = 100.0 ,
237237 skip_by_annotation = ("edge" , "bad_acq_skip" ),
238238 extended_proj = (),
239- st_overlap = None ,
240- mc_interp = None ,
239+ st_overlap = True ,
240+ mc_interp = "hann" ,
241241 verbose = None ,
242242):
243243 """Maxwell filter data using multipole moments.
@@ -287,8 +287,7 @@ def maxwell_filter(
287287 %(extended_proj_maxwell)s
288288 st_overlap : bool
289289 If True (default in 1.11), tSSS processing will use a constant
290- overlap-add method. If False (default in 1.10), then
291- non-overlapping windows will be used.
290+ overlap-add method. If False, then non-overlapping windows will be used.
292291
293292 .. versionadded:: 1.10
294293 %(maxwell_mc_interp)s
@@ -456,8 +455,8 @@ def _prep_maxwell_filter(
456455 skip_by_annotation = ("edge" , "bad_acq_skip" ),
457456 extended_proj = (),
458457 reconstruct = "in" ,
459- st_overlap = False ,
460- mc_interp = "zero " ,
458+ st_overlap = True ,
459+ mc_interp = "hann " ,
461460 verbose = None ,
462461):
463462 # There are an absurd number of different possible notations for spherical
@@ -494,25 +493,7 @@ def _prep_maxwell_filter(
494493 )
495494 if st_only and st_duration is None :
496495 raise ValueError ("st_duration must not be None if st_only is True" )
497- if st_overlap is None :
498- if st_duration is not None :
499- # TODO VERSION 1.10/1.11 deprecation
500- warn (
501- "st_overlap defaults to False in 1.10 but will change to "
502- "True in 1.11. Set it explicitly to avoid this warning." ,
503- DeprecationWarning ,
504- )
505- st_overlap = False
506- add_channels = head_pos is not None and not st_only
507- if mc_interp is None :
508- if head_pos is not None :
509- # TODO VERSION 1.10/1.11 deprecation
510- warn (
511- 'mc_interp defaults to "zero" in 1.10 but will change '
512- 'to "hann" in 1.11, set it explicitly to avoid this '
513- "message." ,
514- DeprecationWarning ,
515- )
496+ if head_pos is None and mc_interp :
516497 mc_interp = "zero"
517498 add_channels = (head_pos is not None ) and (not st_only )
518499 head_pos = _check_pos (head_pos , coord_frame , raw , st_fixed )
@@ -776,7 +757,7 @@ def _run_maxwell_filter(
776757 n = end - onset
777758 assert n > 0
778759 tsss_valid = n >= st_duration
779- if st_overlap and tsss_valid :
760+ if st_overlap and tsss_valid and st_correlation is not None :
780761 n_overlap = st_duration // 2
781762 window = "hann"
782763 else :
@@ -2555,7 +2536,7 @@ def find_bad_channels_maxwell(
25552536 skip_by_annotation = ("edge" , "bad_acq_skip" ),
25562537 h_freq = 40.0 ,
25572538 extended_proj = (),
2558- mc_interp = None ,
2539+ mc_interp = "hann" ,
25592540 verbose = None ,
25602541):
25612542 r"""Find bad channels using Maxwell filtering.
@@ -2754,6 +2735,7 @@ def find_bad_channels_maxwell(
27542735 extended_proj = extended_proj ,
27552736 reconstruct = "orig" ,
27562737 )
2738+ assert params ["st_correlation" ] is None
27572739 del origin , int_order , ext_order , calibration , cross_talk , coord_frame
27582740 del regularize , ignore_ref , bad_condition , head_pos , mag_scale
27592741 good_meg_picks = params ["meg_picks" ][params ["good_mask" ]]
0 commit comments