Merge pull request #62 from snyk/fix/upload-revision-validate-files

Fix/upload revision validate files

Author: paulrosca-snyk

internal/fileupload/errors.go

@@ -20,8 +20,8 @@ type FileCountLimitError = uploadrevision.FileCountLimitError
 // FileAccessError indicates a file access permission issue.
 type FileAccessError = uploadrevision.FileAccessError
 
-// DirectoryError indicates an issue with directory operations.
-type DirectoryError = uploadrevision.DirectoryError
+// SpecialFileError indicates a path points to a special file (device, pipe, socket, etc.) instead of a regular file.
+type SpecialFileError = uploadrevision.SpecialFileError
 
 // HTTPError indicates an HTTP request/response error.
 type HTTPError = uploadrevision.HTTPError

internal/fileupload/uploadrevision/client.go

@@ -195,8 +195,8 @@ func validateFiles(files []UploadFile) error {
 			return NewFileAccessError(file.Path, err)
 		}
 
-		if fileInfo.IsDir() {
-			return NewDirectoryError(file.Path)
+		if !fileInfo.Mode().IsRegular() {
+			return NewSpecialFileError(file.Path, fileInfo.Mode())
 		}
 
 		if fileInfo.Size() > fileSizeLimit {