fix: remove request id header for explain API (#82)

Author: DariusZdroba

llm/api_client.go

@@ -7,26 +7,18 @@ import (
 	"io"
 	"net/http"
 	"net/url"
-
-	"github.com/snyk/code-client-go/observability"
 )
 
 var (
-	completeStatus                = "COMPLETE"
-	failedToObtainRequestIdString = "Failed to obtain request id. "
-	defaultEndpointURL            = "http://localhost:10000/explain"
+	completeStatus     = "COMPLETE"
+	defaultEndpointURL = "http://localhost:10000/explain"
 )
 
 func (d *DeepCodeLLMBindingImpl) runExplain(ctx context.Context, options ExplainOptions) (Explanations, error) {
 	span := d.instrumentor.StartSpan(ctx, "code.RunExplain")
 	defer span.Finish()
 
-	requestId, err := observability.GetTraceId(ctx)
-	logger := d.logger.With().Str("method", "code.RunExplain").Str("requestId", requestId).Logger()
-	if err != nil {
-		logger.Err(err).Msg(failedToObtainRequestIdString + err.Error())
-		return Explanations{}, err
-	}
+	logger := d.logger.With().Str("method", "code.RunExplain").Logger()
 
 	logger.Debug().Msg("API: Retrieving explain for bundle")
 	defer logger.Debug().Msg("API: Retrieving explain done")
@@ -52,7 +44,7 @@ func (d *DeepCodeLLMBindingImpl) runExplain(ctx context.Context, options Explain
 		return Explanations{}, err
 	}
 
-	d.addDefaultHeaders(req, requestId)
+	d.addDefaultHeaders(req)
 
 	resp, err := d.httpClientFunc().Do(req) //nolint:bodyclose // this seems to be a false positive
 	if err != nil {
@@ -111,8 +103,7 @@ func (d *DeepCodeLLMBindingImpl) explainRequestBody(options *ExplainOptions) ([]
 	return requestBody, marshalErr
 }
 
-func (d *DeepCodeLLMBindingImpl) addDefaultHeaders(req *http.Request, requestId string) {
-	req.Header.Set("snyk-request-id", requestId)
+func (d *DeepCodeLLMBindingImpl) addDefaultHeaders(req *http.Request) {
 	req.Header.Set("Cache-Control", "private, max-age=0, no-cache")
 	req.Header.Set("Content-Type", "application/json")
 }

llm/api_client_test.go

@@ -166,19 +166,13 @@ func testLogger(t *testing.T) *zerolog.Logger {
 func TestAddDefaultHeadersWithExistingHeaders(t *testing.T) {
 	d := &DeepCodeLLMBindingImpl{} // Initialize your struct if needed
 	req := &http.Request{Header: http.Header{"Existing-Header": {"existing-value"}}}
-	requestId := "test-request-id"
 
-	d.addDefaultHeaders(req, requestId)
+	d.addDefaultHeaders(req)
 
-	snykRequestId := req.Header.Get("snyk-request-id")
 	cacheControl := req.Header.Get("Cache-Control")
 	contentType := req.Header.Get("Content-Type")
 	existingHeader := req.Header.Get("Existing-Header")
 
-	if snykRequestId != requestId {
-		t.Errorf("Expected snyk-request-id header to be %s, got %s", requestId, snykRequestId)
-	}
-
 	if cacheControl != "private, max-age=0, no-cache" {
 		t.Errorf("Expected Cache-Control header to be 'private, max-age=0, no-cache', got %s", cacheControl)
 	}