-
Notifications
You must be signed in to change notification settings - Fork 1
chore: update to Go 1.24 [IDE-1377] #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update pact-go to 2.4.1. This requires everyone to run `make clean`, which has been updated to clear the old lib file. Update golangci-lint to 1.64.8. Lint project with updated lint rules. Improve updating of golangci-lint, now will be automatically updated if needed before use. Update semver rules to always at least increment patch on each commit to main, since chores previously weren't.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Since 1.24.6 is not out yet.
As noted in snyk/go-application-framework#400 it is better to pin frameworks to minor versions. So I will put this back to WIP. |
Also use cimg/go:1.24
@@ -39,6 +39,7 @@ jobs: | |||
with: | |||
token: ${{ github.token }} | |||
branch: main | |||
noVersionBumpBehavior: patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or would the preference be:
skipInvalidTags: true # Skip non-semver tags
Description
Update pact-go to 2.4.1. This requires everyone to run
make clean
, which has been updated to clear the old lib file.Update golangci-lint to 1.64.8.
Lint project with updated lint rules.
Improve updating of golangci-lint, now will be automatically updated if needed before use.
Update semver rules to always at least increment patch on each commit to main, since chores previously weren't.
Update CircleCI Go base image to 1.24.
Checklist
🚨After having merged, please update the
snyk-ls
and CLI go.mod to pull in latest client.