Skip to content

Conversation

rrama
Copy link
Contributor

@rrama rrama commented Aug 8, 2025

Description

Update pact-go to 2.4.1. This requires everyone to run make clean, which has been updated to clear the old lib file.
Update golangci-lint to 1.64.8.
Lint project with updated lint rules.
Improve updating of golangci-lint, now will be automatically updated if needed before use.
Update semver rules to always at least increment patch on each commit to main, since chores previously weren't.
Update CircleCI Go base image to 1.24.

Checklist

  • Tests added and all succeed
  • None added, just updated with latest lint rules.
  • Linted
  • README.md updated, if user-facing
  • N/A

🚨After having merged, please update the snyk-ls and CLI go.mod to pull in latest client.

Update pact-go to 2.4.1. This requires everyone to run `make clean`, which has been updated to clear the old lib file.
Update golangci-lint to 1.64.8.
Lint project with updated lint rules.
Improve updating of golangci-lint, now will be automatically updated if needed before use.
Update semver rules to always at least increment patch on each commit to main, since chores previously weren't.
Copy link

snyk-io bot commented Aug 8, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@rrama rrama marked this pull request as ready for review August 8, 2025 15:10
@rrama rrama requested review from a team as code owners August 8, 2025 15:10
Since 1.24.6 is not out yet.
@rrama
Copy link
Contributor Author

rrama commented Aug 13, 2025

As noted in snyk/go-application-framework#400 it is better to pin frameworks to minor versions. So I will put this back to WIP.

@rrama rrama marked this pull request as draft August 13, 2025 13:57
@rrama rrama changed the title chore: update to Go 1.24.6 [IDE-1377] WIP chore: update to Go 1.24.6 [IDE-1377] Aug 13, 2025
@rrama rrama changed the title WIP chore: update to Go 1.24.6 [IDE-1377] WIP chore: update to Go 1.24 [IDE-1377] Aug 13, 2025
@@ -39,6 +39,7 @@ jobs:
with:
token: ${{ github.token }}
branch: main
noVersionBumpBehavior: patch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or would the preference be:

skipInvalidTags: true  # Skip non-semver tags

@rrama rrama changed the title WIP chore: update to Go 1.24 [IDE-1377] chore: update to Go 1.24 [IDE-1377] Aug 22, 2025
@rrama rrama marked this pull request as ready for review August 22, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant