fix: panic on not implem and remove useless lock

Martin Guibert · Martin Guibert · commit dcd11f0f02b2 · 2022-08-03T11:52:30.000+02:00
diff --git a/enumeration/enumerator/cloud_enumerator.go b/enumeration/enumerator/cloud_enumerator.go
@@ -8,7 +8,6 @@ import (
 
 	"github.com/snyk/driftctl/enumeration"
 
-	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 	"github.com/snyk/driftctl/enumeration/alerter"
 	"github.com/snyk/driftctl/enumeration/parallel"
@@ -179,7 +178,7 @@ func (e *CloudEnumerator) Refresh(input *enumeration.RefreshInput) (*enumeration
 }
 
 func (e *CloudEnumerator) GetSchema() (*enumeration.GetSchemasOutput, error) {
-	return nil, errors.New("GetSchema is not implemented")
+	panic("GetSchema is not implemented..")
 }
 
 func (e *CloudEnumerator) retrieveRunnerResults(runner *parallel.ParallelRunner) ([]*resource.Resource, error) {
@@ -225,8 +224,6 @@ type sliceAlerter struct {
 }
 
 func (d *sliceAlerter) Alerts() alerter.Alerts {
-	d.lock.Lock()
-	defer d.lock.Unlock()
 	return d.alerts
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ import (`
`8`	`8`
`9`	`9`	`"github.com/snyk/driftctl/enumeration"`
`10`	`10`
`11`		`- "github.com/pkg/errors"`
`12`	`11`	`"github.com/sirupsen/logrus"`
`13`	`12`	`"github.com/snyk/driftctl/enumeration/alerter"`
`14`	`13`	`"github.com/snyk/driftctl/enumeration/parallel"`
`@@ -179,7 +178,7 @@ func (e CloudEnumerator) Refresh(input enumeration.RefreshInput) (*enumeration`
`179`	`178`	`}`
`180`	`179`
`181`	`180`	`func (e CloudEnumerator) GetSchema() (enumeration.GetSchemasOutput, error) {`
`182`		`- return nil, errors.New("GetSchema is not implemented")`
	`181`	`+ panic("GetSchema is not implemented..")`
`183`	`182`	`}`
`184`	`183`
`185`	`184`	`func (e CloudEnumerator) retrieveRunnerResults(runner parallel.ParallelRunner) ([]*resource.Resource, error) {`
`@@ -225,8 +224,6 @@ type sliceAlerter struct {`
`225`	`224`	`}`
`226`	`225`
`227`	`226`	`func (d *sliceAlerter) Alerts() alerter.Alerts {`
`228`		`- d.lock.Lock()`
`229`		`- defer d.lock.Unlock()`
`230`	`227`	`return d.alerts`
`231`	`228`	`}`
`232`	`229`