chore: fixing Helm templating for Tilt

introducing the gh-pages automation broke "helm template snyk-monitor" because it added a templated variable to the values.yaml, so "helm template" fails to render.
this commit fixes it by changing our placeholder with a simple string instead of curly brackets.

Author: Shesekino

scripts/publish-gh-pages.sh

@@ -21,8 +21,8 @@ echo overriding new yaml / chart files from master branch
 git checkout origin/master -- snyk-monitor snyk-monitor-cluster-permissions.yaml snyk-monitor-deployment.yaml snyk-monitor-namespaced-permissions.yaml
 
 echo overriding tag placeholders with latest semantic version
-sed -i "s/{{IMAGE_TAG_OVERRIDE_WHEN_PUBLISHING}}/${NEW_TAG}/g" ./snyk-monitor/values.yaml
-sed -i "s/{{IMAGE_TAG_OVERRIDE_WHEN_PUBLISHING}}/${NEW_TAG}/g" ./snyk-monitor-deployment.yaml
+sed -i "s/IMAGE_TAG_OVERRIDE_WHEN_PUBLISHING/${NEW_TAG}/g" ./snyk-monitor/values.yaml
+sed -i "s/IMAGE_TAG_OVERRIDE_WHEN_PUBLISHING/${NEW_TAG}/g" ./snyk-monitor-deployment.yaml
 
 echo building new helm release
 ./helm init --client-only

snyk-monitor-deployment.yaml

@@ -15,7 +15,7 @@ spec:
         app.kubernetes.io/name: snyk-monitor
     spec:
       containers:
-      - image: snyk/kubernetes-monitor:{{IMAGE_TAG_OVERRIDE_WHEN_PUBLISHING}}
+      - image: snyk/kubernetes-monitor:IMAGE_TAG_OVERRIDE_WHEN_PUBLISHING
         imagePullPolicy: Always
         name: snyk-monitor
         terminationMessagePath: /dev/termination-log

snyk-monitor/values.yaml

@@ -17,7 +17,7 @@ integrationApi: ""
 # The registry from which to pull the snyk-monitor image.
 image:
   repository: snyk/kubernetes-monitor
-  tag: {{IMAGE_TAG_OVERRIDE_WHEN_PUBLISHING}}
+  tag: IMAGE_TAG_OVERRIDE_WHEN_PUBLISHING
   pullPolicy: Always
 
 # The snyk-monitor requires knowing the cluster name so that it can organise