Skip to content

Commit 1aa4b1a

Browse files
committed
chore: remove a TODO from June
it appears that loadFromDefault is working pretty well for us, and seems very standard. if we find users intent on injecting the KubeConfig some other way, we'll handle that.
1 parent bf6072c commit 1aa4b1a

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/kube-scanner/cluster.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,6 @@ import { IK8sClients, K8sClients } from './types';
44

55
function getKubeConfig(): KubeConfig {
66
const kc = new KubeConfig();
7-
// TODO(ivanstanev): We may need to change this to loadFromClusterAndUser()
8-
// and pass the cluster and user from somewhere (e.g. env vars).
9-
// By default, these would be (as taken from the k8s client source):
10-
// { name: 'cluster', server: 'http://localhost:8080' } as Cluster,
11-
// { name: 'user' } as User
12-
// We need to identify what the implications of this are, and whether
13-
// our customers would want to configure this. Keep an eye on this!
147
kc.loadFromDefault();
158
return kc;
169
}

0 commit comments

Comments
 (0)