fix: create PVC only if using the default PVC name

We should create a PVC only if the default PVC name has not changed.
If the name has changed, it means our users want to use their own pre-provisioned PVC.
In such cases it would be an error to create a PVC as it would result in a conflict - the PVC already exists.

Author: ivanstanev

snyk-monitor/templates/pvc.yaml

@@ -1,4 +1,7 @@
-{{ if .Values.pvc.enabled }}
+# We create a PVC only if the default PVC name has not changed.
+# If the name has changed, it means our users want to use their own pre-provisioned PVC.
+# In such cases it would be an error to create a PVC as it would result in a conflict - the PVC already exists.
+{{- if .Values.pvc.enabled }}{{- if eq .Values.pvc.name "snyk-monitor-pvc" }}
 kind: PersistentVolumeClaim
 apiVersion: v1
 metadata:
@@ -11,4 +14,4 @@ spec:
     requests:
       storage: {{ .Values.temporaryStorageSize }}
   storageClassName: {{ .Values.pvc.storageClassName }}
-{{ end }}
+{{- end }}{{- end }}

snyk-monitor/values.yaml

@@ -39,7 +39,7 @@ temporaryStorageSize: 50Gi #  Applies to PVC too
 # Change to true to use a PVC instead of emptyDir for local storage
 pvc:
   enabled: false
-  name: 'snyk-monitor-pvc'
+  name: snyk-monitor-pvc
   storageClassName: null
 
 # Node.js in-container process memory enhancements