chore: convert tap test to jest

Author: jmickey

.circleci/config.yml

@@ -812,7 +812,8 @@ jobs:
                 command: |
                     npm run lint &&
                     npm run build &&
-                    npm run test:unit
+                    npm run test:unit:tap &&
+                    npm run test:unit:jest
                 name: Unit tests
             - run:
                 command: |

.circleci/config/jobs/@jobs.yml

@@ -92,7 +92,8 @@ unit_tests:
         command: |
           npm run lint &&
           npm run build &&
-          npm run test:unit
+          npm run test:unit:tap &&
+          npm run test:unit:jest
     - run:
         name: Notify Slack on failure
         command: |

package.json

@@ -4,8 +4,9 @@
   "main": "dist/index.js",
   "scripts": {
     "pretest": "./scripts/docker/build-image.sh",
-    "test": "npm run lint && npm run build && npm run test:unit && npm run test:integration:kind:helm",
-    "test:unit": "NODE_ENV=test tap test/unit --timeout=300",
+    "test": "npm run lint && npm run build && npm run test:unit:tap && npm run test:unit:jest && npm run test:integration:kind:helm",
+    "test:unit:tap": "NODE_ENV=test tap test/unit/*.test.ts test/unit/**/*.test.ts --timeout=300",
+    "test:unit:jest": "jest --logHeapUsage --ci test/unit",
     "test:system": "jest --logHeapUsage --ci --maxWorkers=1 test/system",
     "test:integration:kind:yaml": "DEPLOYMENT_TYPE=YAML TEST_PLATFORM=kind CREATE_CLUSTER=true jest --logHeapUsage --ci --maxWorkers=1 test/integration/kubernetes.spec.ts",
     "test:integration:kind:helm": "DEPLOYMENT_TYPE=Helm TEST_PLATFORM=kind CREATE_CLUSTER=true jest --logHeapUsage --ci --maxWorkers=1 test/integration/kubernetes.spec.ts",

test/unit/supervisor/pod-watch-handler-caches.test.ts renamed to test/unit/supervisor/pod-watch-handler-caches.spec.ts

@@ -1,20 +1,18 @@
-import * as tap from 'tap';
-import * as sinon from 'sinon';
-import * as sleep from 'sleep-promise';
+import * as async from 'async';
 import * as fs from 'fs';
+import * as sleep from 'sleep-promise';
 import * as YAML from 'yaml';
-import async = require('async');
 
 import { V1PodSpec, V1Pod } from '@kubernetes/client-node';
 import { IWorkload } from '../../../src/transmitter/types';
 import * as metadataExtractor from '../../../src/supervisor/metadata-extractor';
 
 let pushCallCount = 0;
-sinon.stub(async, 'queue').returns({ error: () => { }, push: () => pushCallCount++ } as any);
+const asyncQueueSpy = jest.spyOn(async, 'queue').mockReturnValue({ error: () => {}, push: () => pushCallCount++ } as any);
 
 import * as pod from '../../../src/supervisor/watchers/handlers/pod';
 
-tap.test('image and workload image cache', async (t) => {
+describe('image and workload image cache', () => {
   const podSpecFixture = fs.readFileSync('./test/fixtures/pod-spec.json', 'utf8');
   const podSpec: V1PodSpec = YAML.parse(podSpecFixture);
   const workloadMetadata: IWorkload[] = [
@@ -36,25 +34,33 @@ tap.test('image and workload image cache', async (t) => {
     },
   ];
 
-  sinon.stub(metadataExtractor, 'buildMetadataForWorkload').resolves(workloadMetadata);
 
-  t.teardown(() => {
-    (async['queue'] as any).restore();
-    (metadataExtractor['buildMetadataForWorkload'] as any).restore();
+  const buildMetadataSpy = jest.spyOn(metadataExtractor, 'buildMetadataForWorkload').mockResolvedValue(workloadMetadata);
+
+  afterAll(() => {
+    asyncQueueSpy.mockRestore();
+    buildMetadataSpy.mockRestore();
   });
 
   const podFixture = fs.readFileSync('./test/fixtures/sidecar-containers/pod.yaml', 'utf8');
   const podObject: V1Pod = YAML.parse(podFixture);
-  await pod.podWatchHandler(podObject);
-  await sleep(500);
-  t.equals(pushCallCount, 1, 'pushed data to send');
-
-  await pod.podWatchHandler(podObject);
-  await sleep(500);
-  t.equals(pushCallCount, 1, 'cached info, no data pushed to send');
-
-  workloadMetadata[0].imageId = 'newImageName';
-  await pod.podWatchHandler(podObject);
-  await sleep(1000);
-  t.equals(pushCallCount, 2, 'new image parsed, workload is cached');
+
+  it('pushed data to send', async () => {
+    await pod.podWatchHandler(podObject);
+    await sleep(500);
+    expect(pushCallCount).toEqual(1);
+  });
+
+  it('cached info, no data pushed to send', async () => {
+    await pod.podWatchHandler(podObject);
+    await sleep(500);
+    expect(pushCallCount).toEqual(1);
+  });
+
+  it('new image parsed, workload is cached', async () => {
+    workloadMetadata[0].imageId = 'newImageName';
+    await pod.podWatchHandler(podObject);
+    await sleep(1000);
+    expect(pushCallCount).toEqual(2);
+  });
 });