feat: significantly reduce the number of watches to the Kubernetes API

We now set up only up to 9 watches/informers with the Kubernetes API for the whole cluster instead of up to 9 watches per namespace.
For really large clusters this is a great improvement - instead of setting thousands of watches, we only set up to 9, regardless of the cluster size.

Author: ivanstanev

src/supervisor/watchers/handlers/cron-job.ts

@@ -9,7 +9,7 @@ import { WorkloadKind } from '../../types';
 import { FALSY_WORKLOAD_NAME_MARKER } from './types';
 import { IncomingMessage } from 'http';
 import { k8sApi } from '../../cluster';
-import { paginatedNamespacedList } from './pagination';
+import { paginatedClusterList, paginatedNamespacedList } from './pagination';
 import {
   deleteWorkloadAlreadyScanned,
   deleteWorkloadImagesAlreadyScanned,
@@ -34,6 +34,21 @@ export async function paginatedNamespacedCronJobList(
   );
 }
 
+export async function paginatedClusterCronJobList(): Promise<{
+  response: IncomingMessage;
+  body: V1CronJobList;
+}> {
+  const v1CronJobList = new V1CronJobList();
+  v1CronJobList.apiVersion = 'batch/v1';
+  v1CronJobList.kind = 'CronJobList';
+  v1CronJobList.items = new Array<V1CronJob>();
+
+  return await paginatedClusterList(
+    v1CronJobList,
+    k8sApi.batchClient.listCronJobForAllNamespaces.bind(k8sApi.batchClient),
+  );
+}
+
 export async function paginatedNamespacedCronJobV1Beta1List(
   namespace: string,
 ): Promise<{
@@ -54,6 +69,23 @@ export async function paginatedNamespacedCronJobV1Beta1List(
   );
 }
 
+export async function paginatedClusterCronJobV1Beta1List(): Promise<{
+  response: IncomingMessage;
+  body: V1beta1CronJobList;
+}> {
+  const cronJobList = new V1beta1CronJobList();
+  cronJobList.apiVersion = 'batch/v1beta1';
+  cronJobList.kind = 'CronJobList';
+  cronJobList.items = new Array<V1beta1CronJob>();
+
+  return await paginatedClusterList(
+    cronJobList,
+    k8sApi.batchUnstableClient.listCronJobForAllNamespaces.bind(
+      k8sApi.batchUnstableClient,
+    ),
+  );
+}
+
 export async function cronJobWatchHandler(
   cronJob: V1CronJob | V1beta1CronJob,
 ): Promise<void> {

src/supervisor/watchers/handlers/daemon-set.ts

@@ -4,7 +4,7 @@ import { WorkloadKind } from '../../types';
 import { FALSY_WORKLOAD_NAME_MARKER } from './types';
 import { IncomingMessage } from 'http';
 import { k8sApi } from '../../cluster';
-import { paginatedNamespacedList } from './pagination';
+import { paginatedClusterList, paginatedNamespacedList } from './pagination';
 import {
   deleteWorkloadAlreadyScanned,
   deleteWorkloadImagesAlreadyScanned,
@@ -29,6 +29,21 @@ export async function paginatedNamespacedDaemonSetList(
   );
 }
 
+export async function paginatedClusterDaemonSetList(): Promise<{
+  response: IncomingMessage;
+  body: V1DaemonSetList;
+}> {
+  const v1DaemonSetList = new V1DaemonSetList();
+  v1DaemonSetList.apiVersion = 'apps/v1';
+  v1DaemonSetList.kind = 'DaemonSetList';
+  v1DaemonSetList.items = new Array<V1DaemonSet>();
+
+  return await paginatedClusterList(
+    v1DaemonSetList,
+    k8sApi.appsClient.listDaemonSetForAllNamespaces.bind(k8sApi.appsClient),
+  );
+}
+
 export async function daemonSetWatchHandler(
   daemonSet: V1DaemonSet,
 ): Promise<void> {

src/supervisor/watchers/handlers/deployment-config.ts

@@ -6,7 +6,7 @@ import {
   V1DeploymentConfig,
   V1DeploymentConfigList,
 } from './types';
-import { paginatedNamespacedList } from './pagination';
+import { paginatedClusterList, paginatedNamespacedList } from './pagination';
 import { k8sApi } from '../../cluster';
 import {
   deleteWorkloadAlreadyScanned,
@@ -51,6 +51,38 @@ export async function paginatedNamespacedDeploymentConfigList(
   );
 }
 
+export async function paginatedClusterDeploymentConfigList(): Promise<{
+  response: IncomingMessage;
+  body: V1DeploymentConfigList;
+}> {
+  const v1DeploymentConfigList = new V1DeploymentConfigList();
+  v1DeploymentConfigList.apiVersion = 'apps.openshift.io/v1';
+  v1DeploymentConfigList.kind = 'DeploymentConfigList';
+  v1DeploymentConfigList.items = new Array<V1DeploymentConfig>();
+
+  return await paginatedClusterList(
+    v1DeploymentConfigList,
+    async (
+      _allowWatchBookmarks?: boolean,
+      _continue?: string,
+      fieldSelector?: string,
+      labelSelector?: string,
+      limit?: number,
+      pretty?: string,
+    ) =>
+      k8sApi.customObjectsClient.listClusterCustomObject(
+        'apps.openshift.io',
+        'v1',
+        'deploymentconfigs',
+        pretty,
+        _continue,
+        fieldSelector,
+        labelSelector,
+        limit,
+      ) as any,
+  );
+}
+
 export async function deploymentConfigWatchHandler(
   deploymentConfig: V1DeploymentConfig,
 ): Promise<void> {

src/supervisor/watchers/handlers/deployment.ts

@@ -4,7 +4,7 @@ import { WorkloadKind } from '../../types';
 import { FALSY_WORKLOAD_NAME_MARKER } from './types';
 import { IncomingMessage } from 'http';
 import { k8sApi } from '../../cluster';
-import { paginatedNamespacedList } from './pagination';
+import { paginatedClusterList, paginatedNamespacedList } from './pagination';
 import {
   deleteWorkloadAlreadyScanned,
   deleteWorkloadImagesAlreadyScanned,
@@ -22,15 +22,28 @@ export async function paginatedNamespacedDeploymentList(
   v1DeploymentList.kind = 'DeploymentList';
   v1DeploymentList.items = new Array<V1Deployment>();
 
-  k8sApi.appsClient.listDeploymentForAllNamespaces();
-
   return await paginatedNamespacedList(
     namespace,
     v1DeploymentList,
     k8sApi.appsClient.listNamespacedDeployment.bind(k8sApi.appsClient),
   );
 }
 
+export async function paginatedClusterDeploymentList(): Promise<{
+  response: IncomingMessage;
+  body: V1DeploymentList;
+}> {
+  const v1DeploymentList = new V1DeploymentList();
+  v1DeploymentList.apiVersion = 'apps/v1';
+  v1DeploymentList.kind = 'DeploymentList';
+  v1DeploymentList.items = new Array<V1Deployment>();
+
+  return await paginatedClusterList(
+    v1DeploymentList,
+    k8sApi.appsClient.listDeploymentForAllNamespaces.bind(k8sApi.appsClient),
+  );
+}
+
 export async function deploymentWatchHandler(
   deployment: V1Deployment,
 ): Promise<void> {