Merge pull request #306 from snyk/fix/unexpected-error-structure

fix: check k8s-api error for response before assuming it's there

Author: Amir Moualem

src/supervisor/kuberenetes-api-wrappers.ts

@@ -12,6 +12,10 @@ export async function retryKubernetesApiRequest(func: IKubernetesApiFunction) {
     try {
       return await func();
     } catch (err) {
+      if (!(err.response)) {
+        throw err;
+      }
+
       const response = err.response;
       if (response.statusCode !== 429) {
         throw err;

test/unit/supervisor/kubernetes-api-wrappers.test.ts

@@ -100,3 +100,20 @@ tap.test('retryKubernetesApiRequest for non-retryable errors', async (t) => {
   );
   t.equals(failures, 1, 'did not retry even once for non-retryable error code');
 });
+
+tap.test('retryKubernetesApiRequest for errors without response', async (t) => {
+  const errorWithoutResponse = 'there\'s butter on my face!';
+
+  let failures = 0;
+  const functionThatFails = () => {
+    failures +=1;
+    return Promise.reject(new Error(errorWithoutResponse));
+  };
+
+  t.rejects(
+    () => kubernetesApiWrappers.retryKubernetesApiRequest(functionThatFails),
+    new Error(errorWithoutResponse),
+    'errors without a response property are immediately rethrown',
+  );
+  t.equals(failures, 1, 'did not retry even once for non-retryable error code');
+});