Merge pull request #90 from snyk/feat/resource_limits

feat: add resource limts to the container

Author: shaimendel

snyk-monitor-deployment.yaml

@@ -50,6 +50,13 @@ spec:
                 name: snyk-monitor
                 key: clusterName
                 optional: true
+        resources:
+          requests:
+            cpu: '250m'
+            memory: '400Mi'
+          limits:
+            cpu: '1'
+            memory: '2Gi'
       securityContext: {}
       volumes:
       - name: docker-socket-mount

snyk-monitor/templates/deployment.yaml

@@ -44,6 +44,13 @@ spec:
             value: {{ .Values.integrationApi }}
           - name: SNYK_CLUSTER_NAME
             value: {{ .Values.clusterName }}
+          resources:
+            requests:
+              cpu: '250m'
+              memory: '400Mi'
+            limits:
+              cpu: '1'
+              memory: '2Gi'
       volumes:
         - name: docker-socket-mount
           hostPath:

test/integration/kubernetes.test.ts

@@ -173,3 +173,15 @@ tap.test('snyk-monitor sends deleted workload to homebase', async (t) => {
     `api/v2/workloads/${integrationId}/${clusterName}/${namespace}`);
   t.ok(homebaseDeleteTestResult, 'snyk-monitor sent deleted workload data to homebase in the expected timeframe');
 });
+
+tap.test(`snyk-monitor has resource limits`, async (t) => {
+  t.plan(5);
+  const snykMonitorDeployment = await setup.getDeloymentJson('snyk-monitor', 'snyk-monitor');
+  const monitorResources = snykMonitorDeployment.spec.template.spec.containers[0].resources;
+
+  t.ok(monitorResources !== undefined, 'snyk-monitor has resources');
+  t.ok(monitorResources.requests.cpu !== undefined, 'snyk-monitor has cpu resource request');
+  t.ok(monitorResources.requests.memory !== undefined, 'snyk-monitor has memory resource request');
+  t.ok(monitorResources.requests.cpu !== undefined, 'snyk-monitor has cpu resource request');
+  t.ok(monitorResources.requests.memory !== undefined, 'snyk-monitor has memory resource request');
+});

test/setup.ts

@@ -142,6 +142,11 @@ export async function deleteDeployment(deploymentName: string, namespace: string
   console.log(`Deleted deployment ${deploymentName}!`);
 }
 
+export async function getDeloymentJson(deploymentName: string, namespace: string): Promise<any> {
+  const getDeploymentResult = await exec(`./kubectl get deployment ${deploymentName} -n ${namespace} -o json`);
+  return JSON.parse(getDeploymentResult.stdout);
+}
+
 function createTestYamlDeployment(newYamlPath: string, integrationId: string): void {
   console.log('Creating test deployment...');
   const originalDeploymentYaml = readFileSync('./snyk-monitor-deployment.yaml', 'utf8');