fix: add missing await when pushing workloads to queue

Author: ivanstanev

src/supervisor/watchers/handlers/pod.ts

@@ -59,7 +59,7 @@ export async function handleReadyPod(
 
   const workload = workloadToScan[0];
   if (workloadToScan.length > 0) {
-    workloadsToScanQueue.push({
+    await workloadsToScanQueue.pushAsync({
       key: workload.uid,
       workloadMetadata: workloadToScan,
       enqueueTimestampMs: Date.now(),

test/unit/scanner/scan-results-caching.spec.ts

@@ -36,8 +36,8 @@ describe('scan results caching', () => {
     it('stores workload images to cache and pushes to queue when not already seen', async () => {
       // Arrange
       const queuePushMock = jest
-        .spyOn(workloadsToScanQueue, 'push')
-        .mockReturnValue();
+        .spyOn(workloadsToScanQueue, 'pushAsync')
+        .mockResolvedValue(undefined);
       const setWorkloadImageAlreadyScannedMock = jest
         .spyOn(state, 'setWorkloadImageAlreadyScanned')
         .mockReturnValue(true);
@@ -65,8 +65,8 @@ describe('scan results caching', () => {
     it('stores images to cache and pushes to queue when imageId is different', async () => {
       // Arrange
       const queuePushMock = jest
-        .spyOn(workloadsToScanQueue, 'push')
-        .mockReturnValue();
+        .spyOn(workloadsToScanQueue, 'pushAsync')
+        .mockResolvedValue(undefined);
       const setWorkloadImageAlreadyScannedMock = jest
         .spyOn(state, 'setWorkloadImageAlreadyScanned')
         .mockReturnValue(true);
@@ -103,8 +103,8 @@ describe('scan results caching', () => {
         workload.imageId,
       );
       const queuePushMock = jest
-        .spyOn(workloadsToScanQueue, 'push')
-        .mockReturnValue();
+        .spyOn(workloadsToScanQueue, 'pushAsync')
+        .mockResolvedValue(undefined);
       const setWorkloadImageAlreadyScannedMock = jest
         .spyOn(state, 'setWorkloadImageAlreadyScanned')
         .mockReturnValue(true);

test/unit/supervisor/pod-watch-handler-caches.spec.ts

@@ -4,9 +4,10 @@ import sleep from 'sleep-promise';
 import * as YAML from 'yaml';
 // NOTE: Very important that the mock is set up before application code is imported!
 let pushCallCount = 0;
-const asyncQueueSpy = jest
-  .spyOn(async, 'queue')
-  .mockReturnValue({ error: () => {}, push: () => pushCallCount++ } as any);
+const asyncQueueSpy = jest.spyOn(async, 'queue').mockReturnValue({
+  error: () => {},
+  pushAsync: async () => pushCallCount++,
+} as any);
 
 import { V1PodSpec, V1Pod } from '@kubernetes/client-node';
 import { IWorkload } from '../../../src/transmitter/types';
@@ -56,19 +57,19 @@ describe('image and workload image cache', () => {
   it('pushed data to send', async () => {
     await pod.podWatchHandler(podObject);
     await sleep(500);
-    expect(pushCallCount).toEqual(1);
+    expect(pushCallCount).toEqual(2);
   });
 
   it('cached info, no data pushed to send', async () => {
     await pod.podWatchHandler(podObject);
     await sleep(500);
-    expect(pushCallCount).toEqual(1);
+    expect(pushCallCount).toEqual(2);
   });
 
   it('new image parsed, workload is cached', async () => {
     workloadMetadata[0].imageId = 'newImageName';
     await pod.podWatchHandler(podObject);
     await sleep(1000);
-    expect(pushCallCount).toEqual(2);
+    expect(pushCallCount).toEqual(3);
   });
 });