Skip to content

Commit b8ab73c

Browse files
authored
Merge pull request #410 from snyk/feat/node_12
feat: updated node version to 12
2 parents 62894d3 + a416585 commit b8ab73c

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.circleci/config.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ default_machine_config: &default_machine_config
88

99
default_container_config: &default_container_config
1010
docker:
11-
- image: circleci/node:10
11+
- image: circleci/node:12
1212
working_directory: ~/kubernetes-monitor
1313

1414
python_container_config: &python_container_config
@@ -127,7 +127,7 @@ jobs:
127127
command: |
128128
export NVM_DIR="/opt/circleci/.nvm" &&
129129
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" &&
130-
nvm install v10 &&
130+
nvm install v12 &&
131131
npm install &&
132132
npm run lint &&
133133
npm run build &&
@@ -151,7 +151,7 @@ jobs:
151151
command: |
152152
export NVM_DIR="/opt/circleci/.nvm" &&
153153
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" &&
154-
nvm install v10 &&
154+
nvm install v12 &&
155155
npm install &&
156156
npm run build &&
157157
npm run test:system
@@ -177,7 +177,7 @@ jobs:
177177
command: |
178178
export NVM_DIR="/opt/circleci/.nvm" &&
179179
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" &&
180-
nvm install v10 &&
180+
nvm install v12 &&
181181
npm install &&
182182
docker login --username ${DOCKERHUB_USER} --password ${DOCKERHUB_PASSWORD} &&
183183
export IMAGE_TAG=$([[ "$CIRCLE_BRANCH" == "staging" ]] && echo "staging-candidate" || echo "discardable") &&
@@ -208,7 +208,7 @@ jobs:
208208
command: |
209209
export NVM_DIR="/opt/circleci/.nvm" &&
210210
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" &&
211-
nvm install v10 &&
211+
nvm install v12 &&
212212
npm install &&
213213
docker login --username ${DOCKERHUB_USER} --password ${DOCKERHUB_PASSWORD} &&
214214
export IMAGE_TAG=$([[ "$CIRCLE_BRANCH" == "staging" ]] && echo "staging-candidate" || echo "discardable") &&
@@ -243,7 +243,7 @@ jobs:
243243
command: |
244244
export NVM_DIR="/opt/circleci/.nvm" &&
245245
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" &&
246-
nvm install v10 &&
246+
nvm install v12 &&
247247
npm install &&
248248
docker login --username ${DOCKERHUB_USER} --password ${DOCKERHUB_PASSWORD} &&
249249
export IMAGE_TAG=$([[ "$CIRCLE_BRANCH" == "staging" ]] && echo "staging-candidate" || echo "discardable") &&

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
10
1+
12

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ RUN cd $GOPATH/src/github.com/snyk/go-rpmdb \
2323
#---------------------------------------------------------------------
2424
# STAGE 3: Build the kubernetes-monitor
2525
#---------------------------------------------------------------------
26-
FROM node:dubnium-alpine
26+
FROM node:erbium-alpine
2727

2828
LABEL maintainer="Snyk Ltd"
2929

0 commit comments

Comments
 (0)