Skip to content

Commit be9b3b9

Browse files
committed
chore: rename KubeObjectMetadata to IKubeObjectMetadata
the convention for interface naming we use includes starting their name with a capital I.
1 parent 3693512 commit be9b3b9

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

src/kube-scanner/metadata-extractor.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { V1OwnerReference, V1Pod, V1Container, V1ContainerStatus } from '@kubernetes/client-node';
22
import { IWorkload, ILocalWorkloadLocator } from '../transmitter/types';
33
import { currentClusterName } from './cluster';
4-
import { KubeObjectMetadata } from './types';
4+
import { IKubeObjectMetadata } from './types';
55
import { getSupportedWorkload, getWorkloadReader } from './workload-reader';
66
import logger = require('../common/logger');
77

@@ -10,7 +10,7 @@ const loopingThreshold = 20;
1010
// Constructs the workload metadata based on a variety of k8s properties.
1111
// https://www.notion.so/snyk/Kubernetes-workload-fields-we-should-collect-c60c8f0395f241978282173f4c133a34
1212
export function buildImageMetadata(
13-
workloadMeta: KubeObjectMetadata,
13+
workloadMeta: IKubeObjectMetadata,
1414
containerStatuses: V1ContainerStatus[],
1515
): IWorkload[] {
1616
const { kind, objectMeta, specMeta, revision, podSpec } = workloadMeta;
@@ -49,9 +49,9 @@ export function buildImageMetadata(
4949
async function findParentWorkload(
5050
ownerRefs: V1OwnerReference[] | undefined,
5151
namespace: string,
52-
): Promise<KubeObjectMetadata | undefined> {
52+
): Promise<IKubeObjectMetadata | undefined> {
5353
let ownerReferences = ownerRefs;
54-
let parentMetadata: KubeObjectMetadata | undefined;
54+
let parentMetadata: IKubeObjectMetadata | undefined;
5555

5656
for (let i = 0; i < loopingThreshold; i++) {
5757
// We are interested only in a subset of all workloads.
@@ -76,7 +76,7 @@ async function findParentWorkload(
7676
return undefined;
7777
}
7878

79-
export function buildWorkloadMetadata(kubernetesMetadata: KubeObjectMetadata): ILocalWorkloadLocator {
79+
export function buildWorkloadMetadata(kubernetesMetadata: IKubeObjectMetadata): ILocalWorkloadLocator {
8080
if (!kubernetesMetadata.objectMeta ||
8181
kubernetesMetadata.objectMeta.namespace === undefined ||
8282
kubernetesMetadata.objectMeta.name === undefined) {
@@ -126,7 +126,7 @@ export async function buildMetadataForWorkload(pod: V1Pod): Promise<IWorkload[]
126126
);
127127
}
128128

129-
const podOwner: KubeObjectMetadata | undefined = await findParentWorkload(
129+
const podOwner: IKubeObjectMetadata | undefined = await findParentWorkload(
130130
pod.metadata.ownerReferences, pod.metadata.namespace);
131131

132132
return podOwner === undefined

src/kube-scanner/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export interface IStaticAnalysisOptions {
3232
tmpDirPath: string;
3333
}
3434

35-
export interface KubeObjectMetadata {
35+
export interface IKubeObjectMetadata {
3636
kind: string;
3737
objectMeta: V1ObjectMeta;
3838
specMeta: V1ObjectMeta;

src/kube-scanner/watchers/handlers/workload.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { KubeObjectMetadata } from '../../types';
1+
import { IKubeObjectMetadata } from '../../types';
22
import { buildWorkloadMetadata } from '../../metadata-extractor';
33
import WorkloadWorker = require('../..');
44
import logger = require('../../../common/logger');
55

6-
export async function deleteWorkload(kubernetesMetadata: KubeObjectMetadata, workloadName: string): Promise<void> {
6+
export async function deleteWorkload(kubernetesMetadata: IKubeObjectMetadata, workloadName: string): Promise<void> {
77
try {
88
if (kubernetesMetadata.ownerRefs !== undefined && kubernetesMetadata.ownerRefs.length > 0) {
99
return;

src/kube-scanner/workload-reader.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { V1OwnerReference } from '@kubernetes/client-node';
22
import { k8sApi } from './cluster';
3-
import { KubeObjectMetadata, WorkloadKind } from './types';
3+
import { IKubeObjectMetadata, WorkloadKind } from './types';
44

55
type IWorkloadReaderFunc = (
66
workloadName: string,
77
namespace: string,
8-
) => Promise<KubeObjectMetadata | undefined>;
8+
) => Promise<IKubeObjectMetadata | undefined>;
99

1010
const deploymentReader: IWorkloadReaderFunc = async (workloadName, namespace) => {
1111
const deploymentResult = await k8sApi.appsClient.readNamespacedDeployment(

0 commit comments

Comments
 (0)