Skip to content

Commit c780d10

Browse files
committed
chore: stop returning skopeo's copy result
we're not using the return value of `skopeo.pull`, let's stop returning it and fix the function's signature.
1 parent 2899c9e commit c780d10

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/scanner/images/skopeo.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { SpawnPromiseResult } from 'child-process-promise';
2-
31
import * as processWrapper from '../../common/process';
42
import * as config from '../../common/config';
53
import * as credentials from './credentials';
@@ -33,7 +31,7 @@ function prefixRespository(target: string, type: SkopeoRepositoryType): string {
3331
export async function pull(
3432
image: string,
3533
destination: string,
36-
): Promise<SpawnPromiseResult> {
34+
): Promise<void> {
3735
const creds = await credentials.getSourceCredentials(image);
3836
const credentialsParameters = getCredentialParameters(creds);
3937

@@ -43,7 +41,7 @@ export async function pull(
4341
args.push({body: prefixRespository(image, SkopeoRepositoryType.ImageRegistry), sanitise: false});
4442
args.push({body: prefixRespository(destination, SkopeoRepositoryType.DockerArchive), sanitise: false});
4543

46-
return processWrapper.exec('skopeo', ...args);
44+
processWrapper.exec('skopeo', ...args);
4745
}
4846

4947
export function getCredentialParameters(credentials: string | undefined): Array<processWrapper.IProcessArgument> {

0 commit comments

Comments
 (0)