Skip to content

Commit d843f47

Browse files
committed
chore: candidate unique tag
candidate images will now have a unique name so they may be identified precisely. this can help prevent all sorts of race conditions in our CI that relies on the candidate image for testing and retagging.
1 parent d7b3d54 commit d843f47

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
npm run build &&
3838
npm run test:unit &&
3939
docker login --username ${DOCKERHUB_USER} --password ${DOCKERHUB_PASSWORD} &&
40-
IMAGE_NAME_CANDIDATE=snyk/kubernetes-monitor:staging-candidate &&
40+
IMAGE_NAME_CANDIDATE=snyk/kubernetes-monitor:staging-candidate-${CIRCLE_SHA1} &&
4141
./scripts/build-image.sh ${IMAGE_NAME_CANDIDATE} &&
4242
docker push ${IMAGE_NAME_CANDIDATE} &&
4343
./scripts/slack-notify-push.sh ${IMAGE_NAME_CANDIDATE} &&

scripts/approve-image.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ if [ $1 == "null" ]; then
88
echo Semantic-Release did not create a new version, not pushing a new approved image
99
./scripts/slack-notify-success-no-release.sh
1010
else
11-
IMAGE_NAME_CANDIDATE=snyk/kubernetes-monitor:staging-candidate
11+
IMAGE_NAME_CANDIDATE=snyk/kubernetes-monitor:staging-candidate-${CIRCLE_SHA1}
1212
IMAGE_NAME_APPROVED=snyk/kubernetes-monitor:${1}-approved
1313

1414
docker pull ${IMAGE_NAME_CANDIDATE}

0 commit comments

Comments
 (0)