chore: remove package manager tests

These tests had the purpose of providing us with confidence that we can scan all supported package managers on a variety of images.
They are not bringing us much value, because we already test all package managers with the rest of our fixtures in the general integration tests.
The snyk-docker-plugin that we consume also has sufficient test coverage, so the package manager tests no longer serve their purpose.

Author: ivanstanev

.circleci/config.yml

@@ -31,96 +31,6 @@ main_branches_filter: &main_branches_filter
 
 jobs:
 ######################## PR OR MERGE TO STAGING ########################
-  package_manager_test_apk:
-    <<: *default_machine_config
-    steps:
-      - checkout
-      - run:
-          name: create temp dir for logs
-          command: mkdir -p /tmp/logs/test/integration/kind
-      - run:
-          name: APK Test
-          command: |
-            export NVM_DIR="/opt/circleci/.nvm" &&
-            [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" &&
-            nvm install v10 &&
-            npm install &&
-            export IMAGE_TAG=$([[ "$CIRCLE_BRANCH" == "staging" ]] && echo "staging-candidate" || echo "discardable") &&
-            export KUBERNETES_MONITOR_IMAGE_NAME_AND_TAG=snyk/kubernetes-monitor:${IMAGE_TAG}-${CIRCLE_SHA1} &&
-            docker pull ${KUBERNETES_MONITOR_IMAGE_NAME_AND_TAG} &&
-            npm run test:apk
-      - run:
-          name: Notify Slack on failure
-          command: |
-            if [[ "$CIRCLE_BRANCH" == "staging" ]]; then
-              ./scripts/slack-notify-failure.sh "staging-apk-tests-${CIRCLE_SHA1}"
-            else
-              echo "Current branch is $CIRCLE_BRANCH so skipping notifying Slack"
-            fi
-          when: on_fail
-      - store_artifacts:
-          path: /tmp/logs/test/integration/kind
-
-  package_manager_test_apt:
-    <<: *default_machine_config
-    steps:
-      - checkout
-      - run:
-          name: create temp dir for logs
-          command: mkdir -p /tmp/logs/test/integration/kind
-      - run:
-          name: APT Test
-          command: |
-            export NVM_DIR="/opt/circleci/.nvm" &&
-            [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" &&
-            nvm install v10 &&
-            npm install &&
-            export IMAGE_TAG=$([[ "$CIRCLE_BRANCH" == "staging" ]] && echo "staging-candidate" || echo "discardable") &&
-            export KUBERNETES_MONITOR_IMAGE_NAME_AND_TAG=snyk/kubernetes-monitor:${IMAGE_TAG}-${CIRCLE_SHA1} &&
-            docker pull ${KUBERNETES_MONITOR_IMAGE_NAME_AND_TAG} &&
-            npm run test:apt
-      - run:
-          name: Notify Slack on failure
-          command: |
-            if [[ "$CIRCLE_BRANCH" == "staging" ]]; then
-              ./scripts/slack-notify-failure.sh "staging-apt-tests-${CIRCLE_SHA1}"
-            else
-              echo "Current branch is $CIRCLE_BRANCH so skipping notifying Slack"
-            fi
-          when: on_fail
-      - store_artifacts:
-          path: /tmp/logs/test/integration/kind
-
-  package_manager_test_rpm:
-    <<: *default_machine_config
-    steps:
-      - checkout
-      - run:
-          name: create temp dir for logs
-          command: mkdir -p /tmp/logs/test/integration/kind
-      - run:
-          name: RPM Test
-          command: |
-            export NVM_DIR="/opt/circleci/.nvm" &&
-            [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" &&
-            nvm install v10 &&
-            npm install &&
-            export IMAGE_TAG=$([[ "$CIRCLE_BRANCH" == "staging" ]] && echo "staging-candidate" || echo "discardable") &&
-            export KUBERNETES_MONITOR_IMAGE_NAME_AND_TAG=snyk/kubernetes-monitor:${IMAGE_TAG}-${CIRCLE_SHA1} &&
-            docker pull ${KUBERNETES_MONITOR_IMAGE_NAME_AND_TAG} &&
-            npm run test:rpm
-      - run:
-          name: Notify Slack on failure
-          command: |
-            if [[ "$CIRCLE_BRANCH" == "staging" ]]; then
-              ./scripts/slack-notify-failure.sh "staging-rpm-tests-${CIRCLE_SHA1}"
-            else
-              echo "Current branch is $CIRCLE_BRANCH so skipping notifying Slack"
-            fi
-          when: on_fail
-      - store_artifacts:
-          path: /tmp/logs/test/integration/kind
-
   build_image:
     <<: *default_machine_config
     steps:
@@ -516,18 +426,6 @@ workflows:
           requires:
             - build_image
           <<: *main_branches_filter
-      - package_manager_test_apk:
-          requires:
-            - build_image
-          <<: *main_branches_filter
-      - package_manager_test_apt:
-          requires:
-            - build_image
-          <<: *main_branches_filter
-      - package_manager_test_rpm:
-          requires:
-            - build_image
-          <<: *main_branches_filter
 
   MERGE_TO_STAGING:
     jobs:
@@ -557,28 +455,13 @@ workflows:
             - build_operator
             - upload_operator
           <<: *staging_branch_only_filter
-      - package_manager_test_apk:
-          requires:
-            - build_image
-          <<: *staging_branch_only_filter
-      - package_manager_test_apt:
-          requires:
-            - build_image
-          <<: *staging_branch_only_filter
-      - package_manager_test_rpm:
-          requires:
-            - build_image
-          <<: *staging_branch_only_filter
       - tag_and_push:
           requires:
             - build_image
             - build_operator
             - unit_tests
             - system_tests
             - integration_tests
-            - package_manager_test_apk
-            - package_manager_test_apt
-            - package_manager_test_rpm
           <<: *staging_branch_only_filter
       - deploy_dev:
           requires:

package.json

@@ -13,9 +13,6 @@
     "test:integration:openshift4": "DEPLOYMENT_TYPE=Operator TEST_PLATFORM=openshift4 CREATE_CLUSTER=false tap test/integration/kubernetes.test.ts --timeout=900",
     "test:coverage": "npm run test:unit -- --coverage",
     "test:watch": "tsc-watch --onSuccess 'npm run test:unit'",
-    "test:apk": "DEPLOYMENT_TYPE=YAML TEST_PLATFORM=kind CREATE_CLUSTER=true PACKAGE_MANAGER=apk tap test/integration/package-manager.test.ts --timeout=900",
-    "test:apt": "DEPLOYMENT_TYPE=YAML TEST_PLATFORM=kind CREATE_CLUSTER=true PACKAGE_MANAGER=apt tap test/integration/package-manager.test.ts --timeout=900",
-    "test:rpm": "DEPLOYMENT_TYPE=YAML TEST_PLATFORM=kind CREATE_CLUSTER=true PACKAGE_MANAGER=rpm tap test/integration/package-manager.test.ts --timeout=900",
     "start": "bin/start",
     "prepare": "npm run build",
     "build": "tsc",