Skip to content

Commit f6cd596

Browse files
committed
chore: remove --generator flag for kubectl in tests
We deploy a Pod in our integration tests using the --generator flag of kubectl. Since 1.18 of kubectl, it seems that this flag has been deprecated and is no longer used: "has no effect and will be removed in the future". This was caught by our tests because we try to use the latest version of kubectl, so breaking changes like this will surface.
1 parent 4510198 commit f6cd596

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/helpers/kubectl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export async function applyK8sYaml(pathToYamlDeployment: string, namespace?: str
8989

9090
export async function createPodFromImage(name: string, image: string, namespace: string) {
9191
console.log(`Letting Kubernetes decide how to manage image ${image} with name ${name}`);
92-
await exec(`./kubectl run ${name} --generator=run-pod/v1 --image=${image} -n ${namespace} -- sleep 999999999`);
92+
await exec(`./kubectl run ${name} --image=${image} -n ${namespace} -- sleep 999999999`);
9393
console.log(`Done Letting Kubernetes decide how to manage image ${image} with name ${name}`);
9494
}
9595

0 commit comments

Comments
 (0)