Merge pull request #133 from snyk/develop

Merge develop into master to release

Author: maxjeffos

README.md

@@ -40,25 +40,43 @@ This extension requires that Node.js and npm be installed on the build agent. Th
 ### Simple Application Testing Example
 
 ```
-- task: SnykSecurityScan@0
+- task: SnykSecurityScan@1
   inputs:
     serviceConnectionEndpoint: 'mySnykToken'
     testType: 'app'
-    monitorWhen: 'always'
     failOnIssues: true
+    monitorWhen: 'always'
+```
+
+### If you do not want the Snyk task fail your pipeline when issues are found, but still want to monitor the results in the Snyk UI
+
+To do this, you need to:
+
+- set `failOnIssues` to `false`, which will make sure the Snyk task will not fail your pipeline even if issues (vulnerabilities, etc) are found
+- have `monitorWhen` set to `always` (or just leave `monitorWhen` out, since `always` is the default)
+
+Here's a full example:
+
+```
+- task: SnykSecurityScan@1
+  inputs:
+    serviceConnectionEndpoint: 'mySnykToken'
+    testType: 'app'
+    failOnIssues: false
+    monitorWhen: 'always'
 ```
 
 ### Simple Container Image Testing Example
 
 ```
-- task: SnykSecurityScan@0
+- task: SnykSecurityScan@1
   inputs:
     serviceConnectionEndpoint: 'mySnykToken'
     testType: 'container'
     dockerImageName: 'my-container-image-name'
     dockerfilePath: 'Dockerfile'
-    monitorWhen: 'always'
     failOnIssues: true
+    monitorWhen: 'always'
 ```
 
 ---

ops/deploy/tsconfig.json

@@ -19,6 +19,7 @@
 
     /* Source Map Options */
     "inlineSourceMap": true /* Emit a single file with source maps instead of having a separate file. */,
-    "inlineSources": true /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
+    "inlineSources": true /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */,
+    "useUnknownInCatchVariables": false
   }
 }

package.json

@@ -50,14 +50,13 @@
   "dependencies": {
     "azure-pipelines-task-lib": "2.9.3",
     "jquery": "^3.4.1",
-    "request": "^2.88.0",
     "vss-web-extension-sdk": "^5.141.0"
   },
   "devDependencies": {
     "@semantic-release/changelog": "^5.0.1",
     "@semantic-release/exec": "^5.0.0",
     "@types/jest": "^24.0.18",
-    "@types/node": "^12.7.1",
+    "@types/node": "^16.11.10",
     "@types/q": "^1.5.2",
     "@typescript-eslint/eslint-plugin": "^2.0.0",
     "@typescript-eslint/parser": "^2.0.0",
@@ -70,9 +69,8 @@
     "mock-fs": "^4.10.4",
     "prettier": "^2.3.1",
     "semantic-release": "^17.0.4",
-    "sync-request": "^6.1.0",
     "tfx-cli": "^0.7.11",
     "ts-jest": "^26.3.0",
-    "typescript": "^3.5.3"
+    "typescript": "^4.5.2"
   }
 }

snykTask/task.json

@@ -148,7 +148,7 @@
     }
   ],
   "execution": {
-    "Node": {
+    "Node10": {
       "target": "./dist/index.js"
     }
   }

snykTask/tsconfig.json

@@ -14,6 +14,7 @@
 
     /* Source Map Options */
     "inlineSourceMap": true /* Emit a single file with source maps instead of having a separate file. */,
-    "inlineSources": true /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
+    "inlineSources": true /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */,
+    "useUnknownInCatchVariables": false
   }
 }