fix: clean it up

Author: parker-snyk

.circleci/config.yml

@@ -51,18 +51,6 @@ windows_big: &windows_big
       default: ""
   working_directory: ~/snyk-docker-plugin
 
-windows_medium: &windows_medium
-  executor:
-    name: win/server-2022
-    shell: bash.exe
-    size: medium
-    version: "2023.05.1"
-  parameters:
-    node_version:
-      type: string
-      default: ""
-  working_directory: ~/snyk-docker-plugin
-
 release_defaults: &release_defaults
   resource_class: small
   docker:
@@ -120,17 +108,6 @@ commands:
       - run:
           name: Use currently installed node version
           command: nvm list | awk '/<< parameters.node_version >>/ {print $1}' | xargs nvm use
-  checkout_with_cache:
-    description: Checkout command with caching
-    steps:
-      - restore_cache:
-          keys:
-            - &source-cache source-v1-{{ .Branch }}-{{ .Revision }}
-      - checkout
-      - save_cache:
-          key: *source-cache
-          paths:
-            - ".git"
 
 jobs:
   security-scans:
@@ -147,32 +124,20 @@ jobs:
   install_lint_build:
     <<: *defaults
     steps:
-      - checkout_with_cache
-      - restore_cache:
-          keys:
-            - v2-npm-cache-{{ checksum "package.json" }}
-            - v2-npm-cache-
-      - setup_npm_user
-      - run: npm ci
-      - save_cache:
-          key: v2-npm-cache-{{ checksum "package.json" }}
-          paths:
-            - ~/.npm
+      - install_deps
+      - attach_workspace:
+          at: ~/snyk-docker-plugin
       - run:
           name: Lint
           command: npm run lint
       - run:
           name: Build
           command: npm run build
-      - persist_to_workspace:
-          root: .
-          paths:
-            - node_modules/
-            - dist/
+
   test:
     <<: *defaults
     steps:
-      - checkout_with_cache
+      - checkout
       - setup_remote_docker:
           docker_layer_caching: true
       - attach_workspace:
@@ -201,11 +166,11 @@ jobs:
           name: Install JUnit coverage reporter
           command: npm install --no-save jest-junit
       - run:
-          name: Run Windows tests in parallel
+          name: Run Windows tests
           command: npm run test-jest-windows --reporters=default --reporters=jest-junit
           environment:
             JEST_JUNIT_OUTPUT_DIR: './reports/junit'
-            JEST_JUNIT_ADD_FILE_ATTRIBUTE: 'true'  # We need this to make --split-by=timings work
+            JEST_JUNIT_ADD_FILE_ATTRIBUTE: 'true'
       - store_test_results:
           path: reports
   test_jest_windows_no_docker:
@@ -222,17 +187,18 @@ jobs:
           name: Install JUnit coverage reporter
           command: npm install --no-save jest-junit
       - run:
-          name: Run Windows tests in parallel
+          name: Run Windows tests
           command: npm run test-jest-windows --reporters=default --reporters=jest-junit
           environment:
             JEST_JUNIT_OUTPUT_DIR: './reports/junit'
-            JEST_JUNIT_ADD_FILE_ATTRIBUTE: 'true'  # We need this to make --split-by=timings work
+            JEST_JUNIT_ADD_FILE_ATTRIBUTE: 'true'
       - store_test_results:
           path: reports
   build_cli:
     <<: *defaults
     resource_class: medium
     steps:
+      - setup_remote_docker
       - checkout_and_merge
       - run:
           name: Setup NPM credentials