refactor: rename CliDownloadUrl to CliBaseDownloadURL

nick-y-snyk · nick-y-snyk · commit 06a388eded25 · 2026-01-05T15:54:53.000+01:00
Rename property from CliDownloadUrl to CliBaseDownloadURL across entire codebase for consistency with UI labeling and configuration naming conventions.

Updated files:
- IPersistableOption.cs: Interface property definition
- SnykOptions.cs: Implementation property
- SnykSettings.cs: Persisted settings property
- SnykOptionsManager.cs: Load/Save mappings
- ConfigScriptingBridge.cs: HTML config bridge
- HtmlResourceLoader.cs: Template replacement
- LsSettings.cs: Language server initialization
- SnykCliDownloader.cs: CLI download URL references
- SnykCliOptionsUserControl.cs: UI control binding
- SnykGeneralOptionsDialogPage.cs: Options dialog handler
- SnykCliDownloaderTest.cs: Test mock setup
- SnykUserStorageSettingsServiceTest.cs: Test assertions
diff --git a/Snyk.VisualStudio.Extension.2022/Download/SnykCliDownloader.cs b/Snyk.VisualStudio.Extension.2022/Download/SnykCliDownloader.cs
@@ -52,10 +52,10 @@ public LatestReleaseInfo GetLatestReleaseInfo()
             {
                 Logger.Information("Get latest CLI release info");
 
-                var latestReleaseVersionUrl = string.Format(LatestReleaseVersionUrlScheme, SnykOptions.CliDownloadUrl, SnykOptions.CliReleaseChannel);
+                var latestReleaseVersionUrl = string.Format(LatestReleaseVersionUrlScheme, SnykOptions.CliBaseDownloadURL, SnykOptions.CliReleaseChannel);
                 var latestVersion = webClient.DownloadString(latestReleaseVersionUrl).Replace("\n", string.Empty);
 
-                var latestReleaseDownloadUrl = string.Format(LatestReleaseDownloadUrlScheme, SnykOptions.CliDownloadUrl, "v"+latestVersion);
+                var latestReleaseDownloadUrl = string.Format(LatestReleaseDownloadUrlScheme, SnykOptions.CliBaseDownloadURL, "v"+latestVersion);
 
                 return new LatestReleaseInfo
                 {
diff --git a/Snyk.VisualStudio.Extension.2022/Language/CustomInitializationOptions.cs b/Snyk.VisualStudio.Extension.2022/Language/CustomInitializationOptions.cs
@@ -50,7 +50,7 @@ public class SnykLsInitializationOptions
         public string OutputFormat { get; set; }
         public string EnableDeltaFindings { get; set; }
         public List<FolderConfig> FolderConfigs { get; set; }
-        public string BaseUrl { get; set; }
+        public string CliBaseDownloadUrl { get; set; }
         public int? RiskScoreThreshold { get; set; }
     }
 
diff --git a/Snyk.VisualStudio.Extension.2022/Language/LsSettings.cs b/Snyk.VisualStudio.Extension.2022/Language/LsSettings.cs
@@ -63,7 +63,7 @@ public SnykLsInitializationOptions GetInitializationOptions()
                 DeviceId = options.DeviceId,
                 EnableDeltaFindings = options.EnableDeltaFindings.ToString().ToLower(),
                 FolderConfigs = options.FolderConfigs,
-                BaseUrl = options.CliDownloadUrl,
+                CliBaseDownloadUrl = options.CliBaseDownloadURL,
                 AdditionalEnv = options.AdditionalEnv,
                 RiskScoreThreshold = options.RiskScoreThreshold
             };
diff --git a/Snyk.VisualStudio.Extension.2022/Settings/IPersistableOption.cs b/Snyk.VisualStudio.Extension.2022/Settings/IPersistableOption.cs
@@ -66,7 +66,7 @@ public interface IPersistableOptions
     /// </summary>
     string CliCustomPath { get; set; }
     string CliReleaseChannel { get; set; }
-    string CliDownloadUrl { get; set; }
+    string CliBaseDownloadURL { get; set; }
     ISet<string> TrustedFolders { get; set; }
 
     bool EnableDeltaFindings { get; set; }
diff --git a/Snyk.VisualStudio.Extension.2022/Settings/SnykCliOptionsUserControl.cs b/Snyk.VisualStudio.Extension.2022/Settings/SnykCliOptionsUserControl.cs
@@ -21,7 +21,7 @@ public SnykCliOptionsUserControl(ISnykServiceProvider serviceProvider) : base(se
         protected override void UpdateViewFromOptions()
         {
             this.manageBinariesAutomaticallyCheckbox.Checked = OptionsMemento.BinariesAutoUpdate;
-            this.cliDownloadUrlTextBox.Text = OptionsMemento.CliDownloadUrl;
+            this.cliDownloadUrlTextBox.Text = OptionsMemento.CliBaseDownloadURL;
 
             var cliPath = string.IsNullOrEmpty(OptionsMemento.CliCustomPath)
                 ? SnykCli.GetSnykCliDefaultPath()
diff --git a/Snyk.VisualStudio.Extension.2022/Settings/SnykGeneralOptionsDialogPage.cs b/Snyk.VisualStudio.Extension.2022/Settings/SnykGeneralOptionsDialogPage.cs
@@ -211,7 +211,7 @@ private bool HandleCliConfiguration()
         {
             var memento = this.serviceProvider.Package.SnykCliOptionsDialogPage.SnykCliOptionsUserControl.OptionsMemento;
 
-            this.SnykOptions.CliDownloadUrl = memento.CliDownloadUrl;
+            this.SnykOptions.CliBaseDownloadURL = memento.CliBaseDownloadURL;
 
             var binariesAutoUpdateChanged = this.SnykOptions.BinariesAutoUpdate != memento.BinariesAutoUpdate;
             var releaseChannelChanged = this.SnykOptions.CliReleaseChannel != memento.CliReleaseChannel;
diff --git a/Snyk.VisualStudio.Extension.2022/Settings/SnykOptions.cs b/Snyk.VisualStudio.Extension.2022/Settings/SnykOptions.cs
@@ -33,7 +33,7 @@ public class SnykOptions : ISnykOptions
         public bool BinariesAutoUpdate { get; set; }
         public string CliCustomPath { get; set; }
         public string CliReleaseChannel { get; set; }
-        public string CliDownloadUrl { get; set; }
+        public string CliBaseDownloadURL { get; set; }
         public ISet<string> TrustedFolders { get; set; }
         public bool EnableDeltaFindings { get; set; }
         public List<FolderConfig> FolderConfigs { get; set; }
diff --git a/Snyk.VisualStudio.Extension.2022/Settings/SnykOptionsManager.cs b/Snyk.VisualStudio.Extension.2022/Settings/SnykOptionsManager.cs
@@ -48,7 +48,7 @@ public ISnykOptions Load()
 
                 BinariesAutoUpdate = snykSettings.BinariesAutoUpdateEnabled,
                 CliCustomPath = snykSettings.CustomCliPath,
-                CliDownloadUrl = snykSettings.CliDownloadUrl,
+                CliBaseDownloadURL = snykSettings.CliBaseDownloadURL,
                 CliReleaseChannel = snykSettings.CliReleaseChannel,
                 CurrentCliVersion = snykSettings.CurrentCliVersion,
 
@@ -87,7 +87,7 @@ public void Save(IPersistableOptions options, bool triggerSettingsChangedEvent =
 
             snykSettings.BinariesAutoUpdateEnabled = options.BinariesAutoUpdate;
             snykSettings.CustomCliPath = options.CliCustomPath;
-            snykSettings.CliDownloadUrl = options.CliDownloadUrl;
+            snykSettings.CliBaseDownloadURL = options.CliBaseDownloadURL;
             snykSettings.CliReleaseChannel = options.CliReleaseChannel;
             snykSettings.CurrentCliVersion = options.CurrentCliVersion;
 
diff --git a/Snyk.VisualStudio.Extension.2022/Settings/SnykSettings.cs b/Snyk.VisualStudio.Extension.2022/Settings/SnykSettings.cs
@@ -63,7 +63,7 @@ public SnykSettings()
         public string Token { get; set; } = string.Empty;
         public bool IacEnabled { get; set; } = true;
         public string CliReleaseChannel { get; set; } = SnykCliDownloader.DefaultReleaseChannel;
-        public string CliDownloadUrl { get; set; } = SnykCliDownloader.DefaultBaseDownloadUrl;
+        public string CliBaseDownloadURL { get; set; } = SnykCliDownloader.DefaultBaseDownloadUrl;
         public bool IgnoreUnknownCa { get; set; }
         public string Organization { get; set; }
         public string CustomEndpoint { get; set; }
diff --git a/Snyk.VisualStudio.Extension.2022/UI/Html/ConfigScriptingBridge.cs b/Snyk.VisualStudio.Extension.2022/UI/Html/ConfigScriptingBridge.cs
@@ -332,9 +332,9 @@ private void ApplyCliSettings(IdeConfigData config)
                 options.BinariesAutoUpdate = config.ManageBinariesAutomatically.Value;
             }
 
-            if (config.BaseUrl != null)
+            if (config.CliBaseDownloadURL != null)
             {
-                options.CliDownloadUrl = config.BaseUrl;
+                options.CliBaseDownloadURL = config.CliBaseDownloadURL;
             }
 
             if (config.CliReleaseChannel != null)
diff --git a/Snyk.VisualStudio.Extension.2022/UI/Html/HtmlResourceLoader.cs b/Snyk.VisualStudio.Extension.2022/UI/Html/HtmlResourceLoader.cs
@@ -33,7 +33,7 @@ public static string LoadFallbackHtml(ISnykOptions options)
                         template = template
                             .Replace("{{MANAGE_BINARIES_CHECKED}}", options.BinariesAutoUpdate ? "checked" : "")
                             .Replace("{{CLI_PATH}}", options.CliCustomPath ?? "")
-                            .Replace("{{CLI_BASE_DOWNLOAD_URL}}", options.CliDownloadUrl ?? "")
+                            .Replace("{{CLI_BASE_DOWNLOAD_URL}}", options.CliBaseDownloadURL ?? "")
                             .Replace("{{CHANNEL_STABLE_SELECTED}}", options.CliReleaseChannel == "stable" ? "selected" : "")
                             .Replace("{{CHANNEL_RC_SELECTED}}", options.CliReleaseChannel == "rc" ? "selected" : "")
                             .Replace("{{CHANNEL_PREVIEW_SELECTED}}", options.CliReleaseChannel == "preview" ? "selected" : "");
diff --git a/Snyk.VisualStudio.Extension.2022/UI/Html/IdeConfigData.cs b/Snyk.VisualStudio.Extension.2022/UI/Html/IdeConfigData.cs
@@ -39,7 +39,7 @@ public class IdeConfigData
         // CLI Settings
         public string CliPath { get; set; }
         public bool? ManageBinariesAutomatically { get; set; }
-        public string BaseUrl { get; set; }
+        public string CliBaseDownloadURL { get; set; }
         public string CliReleaseChannel { get; set; }
 
         // Filter Settings
diff --git a/Snyk.VisualStudio.Extension.Tests/SnykCliDownloaderTest.cs b/Snyk.VisualStudio.Extension.Tests/SnykCliDownloaderTest.cs
@@ -19,7 +19,7 @@ public SnykCliDownloaderTest()
         {
             this.progressWorkerMock = new Mock<ISnykProgressWorker>();
             this.optionsMock = new Mock<ISnykOptions>();
-            this.optionsMock.Setup(x => x.CliDownloadUrl).Returns(SnykCliDownloader.DefaultBaseDownloadUrl);
+            this.optionsMock.Setup(x => x.CliBaseDownloadURL).Returns(SnykCliDownloader.DefaultBaseDownloadUrl);
             this.optionsMock.Setup(x => x.CliReleaseChannel).Returns("preview");
         }
 
diff --git a/Snyk.VisualStudio.Extension.Tests/SnykUserStorageSettingsServiceTest.cs b/Snyk.VisualStudio.Extension.Tests/SnykUserStorageSettingsServiceTest.cs
@@ -59,7 +59,7 @@ public void LoadAndSaveGeneralOptions_PersistsChanges()
             options.ApiToken = new AuthenticationToken(AuthenticationType.OAuth, "dummy-token");
             options.BinariesAutoUpdate = true;
             options.CliCustomPath = "C:\\cli\\snyk.exe";
-            options.CliDownloadUrl = "https://cli.download.url";
+            options.CliBaseDownloadURL = "https://cli.download.url";
             options.CliReleaseChannel = "stable";
             options.CurrentCliVersion = "1.2.3";
             options.IacEnabled = true;
@@ -79,7 +79,7 @@ public void LoadAndSaveGeneralOptions_PersistsChanges()
             Assert.Equal("dummy-token", reloadedOptions.ApiToken.ToString());
             Assert.True(reloadedOptions.BinariesAutoUpdate);
             Assert.Equal("C:\\cli\\snyk.exe", reloadedOptions.CliCustomPath);
-            Assert.Equal("https://cli.download.url", reloadedOptions.CliDownloadUrl);
+            Assert.Equal("https://cli.download.url", reloadedOptions.CliBaseDownloadURL);
             Assert.Equal("stable", reloadedOptions.CliReleaseChannel);
             Assert.Equal("1.2.3", reloadedOptions.CurrentCliVersion);
             Assert.True(reloadedOptions.IacEnabled);

Original file line number	Diff line number	Diff line change
`@@ -52,10 +52,10 @@ public LatestReleaseInfo GetLatestReleaseInfo()`
`52`	`52`	`{`
`53`	`53`	`Logger.Information("Get latest CLI release info");`
`54`	`54`
`55`		`- var latestReleaseVersionUrl = string.Format(LatestReleaseVersionUrlScheme, SnykOptions.CliDownloadUrl, SnykOptions.CliReleaseChannel);`
	`55`	`+ var latestReleaseVersionUrl = string.Format(LatestReleaseVersionUrlScheme, SnykOptions.CliBaseDownloadURL, SnykOptions.CliReleaseChannel);`
`56`	`56`	`var latestVersion = webClient.DownloadString(latestReleaseVersionUrl).Replace("\n", string.Empty);`
`57`	`57`
`58`		`- var latestReleaseDownloadUrl = string.Format(LatestReleaseDownloadUrlScheme, SnykOptions.CliDownloadUrl, "v"+latestVersion);`
	`58`	`+ var latestReleaseDownloadUrl = string.Format(LatestReleaseDownloadUrlScheme, SnykOptions.CliBaseDownloadURL, "v"+latestVersion);`
`59`	`59`
`60`	`60`	`return new LatestReleaseInfo`
`61`	`61`	`{`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public class SnykLsInitializationOptions`
`50`	`50`	`public string OutputFormat { get; set; }`
`51`	`51`	`public string EnableDeltaFindings { get; set; }`
`52`	`52`	`public List<FolderConfig> FolderConfigs { get; set; }`
`53`		`- public string BaseUrl { get; set; }`
	`53`	`+ public string CliBaseDownloadUrl { get; set; }`
`54`	`54`	`public int? RiskScoreThreshold { get; set; }`
`55`	`55`	`}`
`56`	`56`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public SnykCliOptionsUserControl(ISnykServiceProvider serviceProvider) : base(se`
`21`	`21`	`protected override void UpdateViewFromOptions()`
`22`	`22`	`{`
`23`	`23`	`this.manageBinariesAutomaticallyCheckbox.Checked = OptionsMemento.BinariesAutoUpdate;`
`24`		`- this.cliDownloadUrlTextBox.Text = OptionsMemento.CliDownloadUrl;`
	`24`	`+ this.cliDownloadUrlTextBox.Text = OptionsMemento.CliBaseDownloadURL;`
`25`	`25`
`26`	`26`	`var cliPath = string.IsNullOrEmpty(OptionsMemento.CliCustomPath)`
`27`	`27`	`? SnykCli.GetSnykCliDefaultPath()`
Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ private bool HandleCliConfiguration()`
`211`	`211`	`{`
`212`	`212`	`var memento = this.serviceProvider.Package.SnykCliOptionsDialogPage.SnykCliOptionsUserControl.OptionsMemento;`
`213`	`213`
`214`		`- this.SnykOptions.CliDownloadUrl = memento.CliDownloadUrl;`
	`214`	`+ this.SnykOptions.CliBaseDownloadURL = memento.CliBaseDownloadURL;`
`215`	`215`
`216`	`216`	`var binariesAutoUpdateChanged = this.SnykOptions.BinariesAutoUpdate != memento.BinariesAutoUpdate;`
`217`	`217`	`var releaseChannelChanged = this.SnykOptions.CliReleaseChannel != memento.CliReleaseChannel;`
Original file line number	Diff line number	Diff line change
`@@ -332,9 +332,9 @@ private void ApplyCliSettings(IdeConfigData config)`
`332`	`332`	`options.BinariesAutoUpdate = config.ManageBinariesAutomatically.Value;`
`333`	`333`	`}`
`334`	`334`
`335`		`- if (config.BaseUrl != null)`
	`335`	`+ if (config.CliBaseDownloadURL != null)`
`336`	`336`	`{`
`337`		`- options.CliDownloadUrl = config.BaseUrl;`
	`337`	`+ options.CliBaseDownloadURL = config.CliBaseDownloadURL;`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`if (config.CliReleaseChannel != null)`