Skip to content

Commit 6f7a9fb

Browse files
andreionciugitbook-bot
authored andcommitted
GITBOOK-9116: ao, CCI style guide review
1 parent 95b96be commit 6f7a9fb

File tree

8 files changed

+69
-35
lines changed

8 files changed

+69
-35
lines changed

docs/SUMMARY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -717,7 +717,7 @@
717717
* [Ignore issues](manage-risk/prioritize-issues-for-fixing/ignore-issues/README.md)
718718
* [How ignores work for Projects imported using an SCM and the CLI](manage-risk/prioritize-issues-for-fixing/ignore-issues/how-ignores-work-for-projects-imported-using-an-scm-and-the-cli.md)
719719
* [Exclude files and ignore issues FAQs](manage-risk/prioritize-issues-for-fixing/ignore-issues/exclude-files-and-ignore-issues-faqs.md)
720-
* [Consistent Ignores for Snyk Code Early Access](manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/README.md)
720+
* [Consistent Ignores for Snyk Code](manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/README.md)
721721
* [Consistent Ignores for Snyk Code API](manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/api.md)
722722
* [Consistent Ignores for Snyk Code CLI](manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/snyk-cli.md)
723723
* [Consistent Ignores for Snyk Code IDE](manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/snyk-ide.md)

docs/manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/README.md

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@
55

66
Snyk Code Consistent Ignores is in Early Access and available only with Enterprise plans. For more information, see [plans and pricing](https://snyk.io/plans/).
77

8-
To make sure Snyk Code Consistent Ignores Early Access meets your needs and requirements, review [Known limitations](known-limitations.md) and [FAQ](consistent-ignores-for-snyk-code-faqs.md) sections.
8+
To ensure Consistent Ignores meets your needs and requirements, review the [FAQ](consistent-ignores-for-snyk-code-faqs.md) section.
99
{% endhint %}
1010

11-
Snyk Code Consistent Ignores helps your teams focus on important tasks by filtering out distractions. 
12-
13-
It makes sure that once an ignore is created, it is consistently respected regardless of how and where the test is run and what branch is being tested. 
11+
Snyk Code Consistent Ignores helps your teams focus on important tasks by filtering out distractions. It ensures that once an ignore is created, it is consistently respected regardless of how and where the test is run and what branch is being tested. 
1412

1513
By filtering out false positives, inapplicable threats, and accepted risks, your security teams can prioritize fixing real problems, and developers can code without interruptions. 
1614

@@ -39,9 +37,9 @@ To create, edit and remove ignores, you need to have a user role assigned with I
3937

4038
## Convert Project-scoped ignores to asset-scoped ignores
4139

42-
{% hint style="info" %}
43-
**Before you begin**
40+
### Conversion setup
4441

42+
{% hint style="info" %}
4543
If you're new to Snyk or with Snyk Code Projects, you can skip this step as there are no existing ignores to be converted.
4644
{% endhint %}
4745

@@ -63,9 +61,9 @@ To convert the issue from a Project-scoped to an asset-scoped ignore, select **I
6361

6462
You can manage ignores proactively using group-level Snyk Code security policies. As a general rule, you can apply ignore policies when you identify a recurring need to apply similar individual ignores. 
6563

66-
To manage the ignores through security policies, Snyk Code Consistent Ignores need to be enabled at the Group level by your Snyk team. You will not require [conversion](./#convert-project-scoped-ignores-to-asset-scoped-ignores) for any previously applied Group level policy ignores.
64+
To manage the ignores through security policies, Snyk Code Consistent Ignores need to be enabled at the Group level by your Snyk team. You do not require [conversion](./#convert-project-scoped-ignores-to-asset-scoped-ignores) for any previously applied Group level policy ignores.
6765

68-
Policies configured to ignore based Project attributes will not result in ignores being applied in Snyk CLI and IDE settings where a Snyk Project is not available.
66+
Policies configured to ignore-based Project attributes do not result in ignores being applied in Snyk CLI and IDE settings where a Snyk Project is not available.
6967

7068
| Criteria | Description |
7169
| -------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
@@ -76,15 +74,11 @@ Policies configured to ignore based Project attributes will not result in ignore
7674

7775
You can take action from Project issues, but Snyk will apply any ignores to the underlying asset-scoped findings that can span across Snyk Projects, integrations, and branches.
7876

79-
{% hint style="info" %}
80-
**Before you begin**
81-
8277
When you create, modify, or delete an ignore, you must [retest the Project](../../../../scan-with-snyk/snyk-code/manage-code-vulnerabilities/#retesting-code-repository) to update the issue status. 
8378

8479
An indicator at the top of the Project page will notify you if a retest is needed to capture policy or ignore updates. 
8580

8681
Project retests typically occur on a nightly or weekly basis, but you can also retest manually.
87-
{% endhint %}
8882

8983
### Create ignore
9084

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
# API
1+
# Consistent Ignores for Snyk Code API
22

33
{% hint style="info" %}
44
**Release status**
55

66
Snyk Code Consistent Ignores is in Early Access and available only with Enterprise plans. For more information, see [plans and pricing](https://snyk.io/plans/).
77

8-
To make sure Snyk Code Consistent Ignores Early Access meets your needs and requirements, review [Known limitations](known-limitations.md) and [FAQ](consistent-ignores-for-snyk-code-faqs.md) sections.
8+
To ensure Consistent Ignores meets your needs and requirements, review the [FAQ](consistent-ignores-for-snyk-code-faqs.md) section.
99
{% endhint %}
1010

1111
You can manage ignores individually through the [Snyk Policies API (REST)](https://apidocs.snyk.io/version=2024-10-14~experimental?version=2024-10-15#get-/orgs/-org_id-/policies). 
1212

1313
The SARIF output from Snyk CLI contains the `snyk/asset/finding/v1` identifier used to manage ignores at the start of the Early Access program. 
1414

15-
This API leverages the `snyk/asset/finding/v1` identifier and not the `issueId` used by the legacy ignores API. You should prepare to migrate any scripts or automation that rely on the legacy ignores API to the new policy API.
15+
This API leverages the `snyk/asset/finding/v1` identifier and not the `issueId` used by the legacy ignores API. Consider migrating any scripts or automation that rely on the legacy ignores API to the new policy API.

docs/manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/consistent-ignores-for-snyk-code-faqs.md

Lines changed: 42 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,47 @@
44
**Release status**
55

66
Snyk Code Consistent Ignores is in Early Access and available only with Enterprise plans. For more information, see [plans and pricing](https://snyk.io/plans/).
7-
8-
To make sure Snyk Code Consistent Ignores Early Access meets your needs and requirements, review [Known limitations](known-limitations.md) and [FAQ](consistent-ignores-for-snyk-code-faqs.md) sections.
97
{% endhint %}
108

11-
This FAQ section addresses common concerns about the Snyk Code Consistent Identity Early Access program. You can share feedback with your Snyk account team about these items. Snyk will consider all suggestions but implementation or addressing these issues is not guaranteed for the upcoming GA version.
9+
This FAQ section addresses common concerns about the Snyk Code Consistent Identity Early Access program. You can share feedback about these items with your Snyk account team. 
10+
11+
## Snyk Code CLI Upload 
12+
13+
Snyk Code Consistent Ignores does not support ignores for Projects associated with CLI Upload. 
14+
15+
If you activate a Snyk Organization with Snyk Code CLI Upload Projects, ignores for any subsequent scans using `snyk code test --report` are not taken into account. All resulting Projects and associated issues are shown as open. Additionally, any pre-existing [Project-scoped ignores will not be converted to asset-scoped ignores](./#convert-project-scoped-ignores-to-asset-scoped-ignores). 
16+
17+
<figure><img src="../../../../.gitbook/assets/Ignored-issue-using-legacy-system.png" alt=""><figcaption><p>Snyk Code Consistent Ignores limitation in CLI upload</p></figcaption></figure>
18+
19+
### Recommendation
20+
21+
If you're using Snyk Code CLI Upload Projects, consider postponing Consistent Ignores enablement until these workflows are supported.
22+
23+
If you want to try out Snyk Code Consistent Ignores, you can enable it for Organizations that do not have Snyk Code CLI Upload Projects.
24+
25+
## Finding identifier added to Issues API and Reporting&#x20;
26+
27+
There are no changes to the [Group](https://apidocs.snyk.io/?version=2024-10-15#get-/orgs/-org_id-/issues) and [Organization](https://apidocs.snyk.io/?version=2024-10-15#get-/orgs/-org_id-/issues) level Issues API endpoints or Reporting (issue reporting).
28+
29+
An additional attribute containing the finding identifier will be added to these API endpoints and issue reports in the coming months. You can use this to assist you in converting from Project-scoped to asset-scoped ignores, especially at scale or if you have competing ignores across different Projects.
30+
31+
## Bulk ignore conversion
32+
33+
You need to migrate pre-existing Project-scoped ignores to asset-scoped ignores manually on the Projects page.
34+
35+
You may be able to script some of the migration using the CLI, as the CLI output returns both the `issueId` value used in the v1 ignores API, and the `snyk/assets/finding/v1` ID used to manage asset-scoped ignores. The bulk ignore conversion needs to be done at the repository level.&#x20;
36+
37+
### Recommendation
38+
39+
If you need support with the migration, reach out to your Snyk account teams or request time with Snyk product management to share feedback on what will make this process easier for you.
40+
41+
### Support for Bitbucket Data Center/Server <a href="#support-for-bitbucket-data-center-server" id="support-for-bitbucket-data-center-server"></a>
42+
43+
When testing a Bitbucket Server repository, the ignores created are not respected across Projects imported through an SCM integration, Snyk CLI, and IDE.
44+
45+
#### Recommendation <a href="#recommendation-2" id="recommendation-2"></a>
46+
47+
Postpone activating Snyk Code Consistent Ignores until Bitbucket Data Center/Server is fully supported.
1248

1349
## Ignore limitations outside my Snyk Organization
1450

@@ -18,7 +54,7 @@ Depending on feedback during the Early Access period, we may offer a broader sco
1854

1955
## Existing DeepCode inline ignores (legacy) are not supported or migrated
2056

21-
Deepcode inline ignores are a legacy feature that is only available for certain customers. If you have pre-existing Deepcode inline ignores, Snyk will remove them from test results. They will not be marked as `Open` or `Ignored`.
57+
Deepcode inline ignores are a legacy feature that is only available for certain customers. If you have pre-existing Deepcode inline ignores, Snyk removes them from the test results. The results are not marked as `Open` or `Ignored`.
2258

2359
### Recommendation
2460

@@ -39,7 +75,7 @@ Snyk may fail to complete testing after you rename a repository, depending on wh
3975
1. Delete all targets associated with that repository.
4076
2. Reimport the newly renamed repository.
4177

42-
Previous Consistent Ignores will apply to the newly named repository. New clones in IDEs/CLI that reference the new name will also take into account ignores, even with the old git URL, in case some developers haven't updated their remote repositories.
78+
Previous Consistent Ignores are applied to the newly named repository. New clones in IDEs/CLI that reference the new name take into account the ignores, even with the old git URL, in case some developers haven't updated their remote repositories.
4379

4480
## Granular ignores
4581

@@ -49,7 +85,7 @@ If you have specific use cases that require this functionality, reach out to you
4985

5086
## Project attribute policies
5187

52-
Policies defined against Project attributes will continue to work within Snyk Projects where the attributes match. However, they will not apply across the repository to other Projects or in Snyk IDE, CLI, or PR checks flows. To apply policies across Projects and branches for the same repository, define them against Organizations.
88+
Policies defined against Project attributes will continue to work within Snyk Projects where the attributes match. The policies are not applied across the repository to other Projects or in Snyk IDE, CLI, or PR checks flows. To apply policies across Projects and branches for the same repository, define them against Organizations.
5389

5490
## CI/CD support for snyk test --code
5591

docs/manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/known-limitations.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
1+
---
2+
hidden: true
3+
---
4+
15
# Known limitations
26

37
{% hint style="info" %}
48
**Release status**
59

610
Snyk Code Consistent Ignores is in Early Access and available only with Enterprise plans. For more information, see [plans and pricing](https://snyk.io/plans/).
711

8-
To make sure Snyk Code Consistent Ignores Early Access meets your needs and requirements, review [Known limitations](known-limitations.md) and [FAQ](consistent-ignores-for-snyk-code-faqs.md) sections.
12+
To ensure Snyk Code Consistent Ignores Early Access meets your needs and requirements, review the [Known limitations](known-limitations.md) and [FAQ](consistent-ignores-for-snyk-code-faqs.md) sections.
913
{% endhint %}
1014

1115
The following items are planned to be delivered in the months following the Early Access program.

docs/manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/snyk-cli.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
Snyk Code Consistent Ignores is in Early Access and available only with Enterprise plans. For more information, see [plans and pricing](https://snyk.io/plans/).
77

8-
To make sure Snyk Code Consistent Ignores Early Access meets your needs and requirements, review [Known limitations](known-limitations.md) and [FAQ](consistent-ignores-for-snyk-code-faqs.md) sections.
8+
To ensure Consistent Ignores meets your needs and requirements, review the [FAQ](consistent-ignores-for-snyk-code-faqs.md) section.
99
{% endhint %}
1010

1111
Ignores are taken into account in the Snyk CLI when `snyk code test` is run.
@@ -32,9 +32,9 @@ The CLI display output hides ignored results by default when you run `snyk code
3232

3333
## View ignores in Snyk CLI
3434

35-
After running `snyk code test`, the CLI will display a hint about using the `--include-ignores` parameter to show ignored results.
35+
After running `snyk code test`, the CLI displays a hint about using the `--include-ignores` parameter to show ignored results.
3636

37-
Running `snyk code test --include-ignores` will display ignored results with their metadata below the open results.
37+
Running `snyk code test --include-ignores` shows ignored results with their metadata below the open results.
3838

3939
<figure><img src="../../../../.gitbook/assets/display-ignores-snyk-cli.png" alt=""><figcaption><p>Ignores in Snyk CLI</p></figcaption></figure>
4040

docs/manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/snyk-ide.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
Snyk Code Consistent Ignores is in Early Access and available only with Enterprise plans. For more information, see [plans and pricing](https://snyk.io/plans/).
77

8-
To make sure Snyk Code Consistent Ignores Early Access meets your needs and requirements, review [Known limitations](known-limitations.md) and [FAQ](consistent-ignores-for-snyk-code-faqs.md) sections.
8+
To ensure Consistent Ignores meets your needs and requirements, review the [FAQ](consistent-ignores-for-snyk-code-faqs.md) section.
99
{% endhint %}
1010

1111
When you run tests in any of the [four supported Snyk IDE plugins](../../../../scm-ide-and-ci-cd-integrations/snyk-ide-plugins-and-extensions/), the plugins will take into account your ignores.
@@ -31,6 +31,6 @@ The IDE display output hides ignored results by default to maintain developer fo
3131

3232
## View ignores in Snyk IDE
3333

34-
You can apply filters in the plugin settings to show ignored results alongside open results or in isolation. When you set ignored issues to display, the issues and their details will appear in the plugin.
34+
You can apply filters in the plugin settings to show ignored results alongside open results or in isolation. When you set ignored issues to display, the issues and their details appear in the plugin.
3535

3636
<figure><img src="../../../../.gitbook/assets/snyk-code-ignored-issue-ide.png" alt=""><figcaption><p>View ignores in Snyk IDE</p></figcaption></figure>

docs/manage-risk/prioritize-issues-for-fixing/ignore-issues/consistent-ignores-for-snyk-code-early-access/snyk-pull-request-checks.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
# Snyk Pull Request Checks
1+
# Consistent Ignores for Snyk Code Pull Request Checks
22

33
{% hint style="info" %}
44
**Release status**
55

66
Snyk Code Consistent Ignores is in Early Access and available only with Enterprise plans. For more information, see [plans and pricing](https://snyk.io/plans/).
77

8-
To make sure Snyk Code Consistent Ignores Early Access meets your needs and requirements, review [Known limitations](known-limitations.md) and [FAQ](consistent-ignores-for-snyk-code-faqs.md) sections.
8+
To ensure Consistent Ignores meets your needs and requirements, review the [FAQ](consistent-ignores-for-snyk-code-faqs.md) section.
99
{% endhint %}
1010

1111
## Pull Request Check default ignore behavior
1212

13-
When viewing a pull request (PR) check from Snyk in your integrated SCM, ignored findings do not contribute to the PR check outcome. A PR check will not fail due to an ignored finding. Additionally, the Snyk PR experience will include the count of active (unignored) findings in the summary comment and display each finding as an inline comment within the PR.
13+
When viewing a pull request (PR) check from Snyk in your integrated SCM, ignored findings do not contribute to the PR check outcome. A PR check does not fail due to an ignored finding. Additionally, the Snyk PR experience includes the count of active (unignored) findings in the summary comment and displays each finding as an inline comment within the PR.
1414

15-
If a finding is ignored after a PR check has already been completed, the PR check must be retriggered by committing again to the PR. Upon retriggering, the PR check the following changes will occur:
15+
If a finding is ignored after a PR check has already been completed, the PR check must be retriggered by committing again to the PR. Upon retriggering, the PR check the following changes occur:
1616

17-
• The ignored finding will no longer be counted in the summary table.
17+
• The ignored finding is no longer counted in the summary table.
1818

19-
• The inline comment for the ignored finding will be collapsed by default and marked as resolved.
19+
• The inline comment for the ignored finding is collapsed by default and marked as resolved.
2020

2121
Ignores are respected in[ Snyk Code Pull Request Checks](../../../../scan-with-snyk/pull-requests/pull-request-checks/) regardless of whether they are created through [policy](./#manage-ignores-at-the-group-level-through-security-policies) or for an [individual `snyk/assets/finding/v1` value](./#manage-ignores-in-snyk-projects).
2222

@@ -36,6 +36,6 @@ Before being ignored, the finding appears as an inline comment in your SCM integ
3636

3737
<figure><img src="../../../../.gitbook/assets/finding-before-ignore.png" alt=""><figcaption><p>PR check ignored finding details in GitHub </p></figcaption></figure>
3838

39-
After an ignore is applied, and a PR check is re-triggered, the inline comment for the ignored finding is collapsed by default and marked as resolved.&#x20;
39+
After an ignore is applied and a PR check is re-triggered, the inline comment for the ignored finding is collapsed by default and marked as resolved.&#x20;
4040

4141
<figure><img src="../../../../.gitbook/assets/finding-after-ignored-collapsed-view.png" alt=""><figcaption><p>Collapsed view of a finding in Github</p></figcaption></figure>

0 commit comments

Comments
 (0)