fix: ignore the cli checksum when looking for clis without auto-downloads (#726)

If our plugin isn't managing the cli, then we never set use or compare the
checksum. However, when the downloader looked for the cli, it checked for a
state-stored checksum as well, and showed an error dialog if either were
missing.

This error doesn't stop the CLI from loading, nor does it compare the checksum
(which happens elsewhere for auto-downloads). If the plugin never downloaded
the cli, there's no checksum, and you get an error no matter what.

Change the logic to only look for the cli existing when auto-downloads are
disabled.

Author: jbowes

src/snyk/common/services/downloadService.ts

@@ -43,7 +43,10 @@ export class DownloadService {
           'Automatic dependency management is disabled — skipping CLI download/update. ' +
             'Enable "Automatic Dependency Management" in Snyk settings to allow automatic CLI updates.',
         );
-        if (!cliInstalled) {
+        // Check for a configured CLI path. We don't examine checksum here, as we aren't auto-downloading.
+        const cliPath = await this.configuration.getCliPath();
+        const cliExecutableExists = await CliExecutable.exists(cliPath);
+        if (!cliExecutableExists) {
           throw new Error(
             'The Snyk CLI is not installed. Please download it manually or enable "Automatic Dependency Management" in Snyk settings.',
           );

src/test/unit/common/services/downloadService.test.ts

@@ -106,7 +106,7 @@ suite('DownloadService', () => {
       getCliPath: () => Promise.resolve('path/to/cli'),
     } as IConfiguration;
     const service = new DownloadService(context, configuration, cliApi, windowMock, logger, downloader);
-    stub(service, 'isCliInstalled').resolves(true);
+    stub(CliExecutable, 'exists').resolves(true);
     const downloadSpy = stub(service, 'download');
     const updateSpy = stub(service, 'update');
 
@@ -193,7 +193,7 @@ suite('DownloadService', () => {
       getCliPath: () => Promise.resolve('path/to/cli'),
     } as IConfiguration;
     const service = new DownloadService(context, configuration, cliApi, windowMock, logger, downloader);
-    stub(service, 'isCliInstalled').resolves(true);
+    stub(CliExecutable, 'exists').resolves(true);
 
     await service.downloadOrUpdate();
 
@@ -210,7 +210,7 @@ suite('DownloadService', () => {
       getCliPath: () => Promise.resolve('path/to/cli'),
     } as IConfiguration;
     const service = new DownloadService(context, configuration, cliApi, windowMock, logger, downloader);
-    stub(service, 'isCliInstalled').resolves(false);
+    stub(CliExecutable, 'exists').resolves(false);
 
     let thrownError: Error | undefined;
     try {
@@ -234,7 +234,7 @@ suite('DownloadService', () => {
       getCliPath: () => Promise.resolve('path/to/cli'),
     } as IConfiguration;
     const service = new DownloadService(context, configuration, cliApi, windowMock, logger, downloader);
-    stub(service, 'isCliInstalled').resolves(true);
+    stub(CliExecutable, 'exists').resolves(true);
 
     const result = await service.downloadOrUpdate();