Merge pull request #409 from ericbn/git-config

Only call sub git_config_raw once

Author: scottchiefbaker

diff-so-fancy

@@ -434,30 +434,19 @@ sub boolean {
 	}
 }
 
-# Memoize getting the git config
+# Get the git config
 sub git_config_raw {
-	state $static_config;
-
-	if ($static_config) {
-		# If we already have the config return that
-		return $static_config;
-	}
-
 	my $cmd = "git config --list";
 	my @out = `$cmd`;
 
-	$static_config = \@out;
-
 	return \@out;
 }
 
-# Fetch a textual item from the git config
+# Memoize fetching a textual item from the git config
 sub git_config {
 	my $search_key    = lc($_[0] || "");
 	my $default_value = lc($_[1] || "");
 
-	my $out = git_config_raw();
-
 	# If we're in a unit test, use the default (don't read the users config)
 	if (in_unit_test()) {
 		return $default_value;
@@ -472,6 +461,8 @@ sub git_config {
 		print "Parsing git config\n";
 	}
 
+	my $out = git_config_raw();
+
 	foreach my $line (@$out) {
 		if ($line =~ /=/) {
 			my ($key,$value) = split("=",$line,2);