chore: some coverage

Author: HZaim

src/main/java/br/com/grupo63/techchallenge/payment/gateway/payment/PaymentJpaAdapter.java

@@ -16,7 +16,7 @@ public class PaymentJpaAdapter implements IPaymentGateway {
     public Payment saveAndFlush(Payment payment) {
         PaymentPersistenceEntity entity = new PaymentPersistenceEntity(payment);
 
-        entity = paymentJpaRepository.saveAndFlush(entity);
+        entity = paymentJpaRepository.save(entity);
 
         return entity.toModel();
     }

src/main/java/br/com/grupo63/techchallenge/payment/gateway/payment/PaymentJpaRepository.java

@@ -14,5 +14,4 @@ public interface PaymentJpaRepository extends JpaRepository<PaymentPersistenceEn
     @Query("SELECT p FROM PaymentPersistenceEntity p WHERE p.orderId = :orderId")
     Optional<PaymentPersistenceEntity> findByOrderId(Long orderId);
 
-    PaymentPersistenceEntity saveAndFlush(PaymentPersistenceEntity paymentPersistenceEntity);
 }

src/main/java/br/com/grupo63/techchallenge/payment/usecase/PaymentUseCase.java

@@ -15,15 +15,15 @@
 @Service
 public class PaymentUseCase implements IPaymentUseCase {
 
-    private final IMercadoPagoGateway mercadoPagoService;
+    private final IMercadoPagoGateway mercadoPagoGateway;
     private final IOrderGateway orderGateway;
     private final IPaymentGateway paymentGateway;
 
     @Override
     public String startPayment(Long orderId) throws NotFoundException {
         OrderDTO orderDTO = orderGateway.getOrderById(orderId).orElseThrow(NotFoundException::new);
 
-        String qrData = mercadoPagoService.generateQRCode(orderDTO.getId(), orderDTO.getTotalPrice());
+        String qrData = mercadoPagoGateway.generateQRCode(orderDTO.getId(), orderDTO.getTotalPrice());
 
         Payment payment = new Payment(null, false, PaymentStatus.PENDING, PaymentMethod.MERCADO_PAGO_QR_CODE, qrData, orderDTO.getId());
 

src/test/java/br/com/grupo63/techchallenge/payment/PaymentIntegrationTest.java

@@ -63,7 +63,6 @@ void setUp() {
     public void testGetPaymentStatus_EndToEnd() {
         when(paymentJpaRepository.findByOrderId(defaultOrderId)).thenReturn(Optional.of(defaultPaymentPersistenceEntity));
         when(orderGateway.getOrderById(defaultOrderId)).thenReturn(Optional.of(orderDTO));
-        when(mercadoPagoGateway.generateQRCode(defaultOrderId, totalPrice)).thenReturn(qrData);
 
         ResponseEntity<PaymentStatusResponseDTO> response = paymentAPIController.getStatusByOrderId(defaultOrderId);
         assertEquals(HttpStatus.OK, response.getStatusCode());
@@ -73,11 +72,13 @@ public void testGetPaymentStatus_EndToEnd() {
     @SneakyThrows
     @Test
     public void testStartPayment_EndToEnd() {
-        when(paymentJpaRepository.saveAndFlush(any())).thenReturn(defaultPaymentPersistenceEntity);
+        when(paymentJpaRepository.save(any())).thenReturn(defaultPaymentPersistenceEntity);
         when(orderGateway.getOrderById(defaultOrderId)).thenReturn(Optional.of(orderDTO));
+        when(mercadoPagoGateway.generateQRCode(defaultOrderId, totalPrice)).thenReturn(qrData);
 
         ResponseEntity<QRCodeResponseDTO> response = paymentAPIController.startPayment(defaultOrderId);
         assertEquals(HttpStatus.OK, response.getStatusCode());
+        assertEquals(response.getBody().getQrData(), qrData);
     }
 
     @SneakyThrows
@@ -86,7 +87,7 @@ public void testfinishPayment_EndToEnd() {
         when(paymentJpaRepository.findByOrderId(defaultOrderId)).thenReturn(Optional.of(defaultPaymentPersistenceEntity));
 
         payment.setStatus(PaymentStatus.PAID);
-        when(paymentJpaRepository.saveAndFlush(any())).thenReturn(defaultPaymentPersistenceEntity);
+        when(paymentJpaRepository.save(any())).thenReturn(defaultPaymentPersistenceEntity);
 
         ResponseEntity response = paymentAPIController.confirmPaymentFromOrderId(defaultOrderId);
         assertEquals(HttpStatus.OK, response.getStatusCode());