fix: get order endpoint (#4)

Author: HenriqueZaim

src/main/java/br/com/grupo63/techchallenge/payment/gateway/order/IOrderGateway.java

@@ -2,16 +2,16 @@
 
 import br.com.grupo63.techchallenge.payment.gateway.order.dto.OrderDTO;
 import org.springframework.cloud.openfeign.FeignClient;
+import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestMethod;
-import org.springframework.web.bind.annotation.RequestParam;
 
 import java.util.Optional;
 
-@FeignClient(name = "order", url = "${urls.baseurl}")
+@FeignClient(name = "orders", url = "${urls.baseurl}")
 public interface IOrderGateway {
 
-    @RequestMapping(method = RequestMethod.GET, value = "${urls.orders}")
-    Optional<OrderDTO> getOrderById(@RequestParam("orderId") Long orderId);
+    @RequestMapping(method = RequestMethod.GET, value = "${urls.orders}/{orderId}")
+    Optional<OrderDTO> getOrderById(@PathVariable("orderId") Long orderId);
 
 }

src/main/java/br/com/grupo63/techchallenge/payment/gateway/order/dto/OrderDTO.java

@@ -11,6 +11,5 @@
 @NoArgsConstructor
 public class OrderDTO {
 
-    private Long id;
     private Double totalPrice;
 }

src/main/java/br/com/grupo63/techchallenge/payment/usecase/PaymentUseCase.java

@@ -25,9 +25,9 @@ public class PaymentUseCase implements IPaymentUseCase {
     public String startPayment(Long orderId) throws NotFoundException {
         OrderDTO orderDTO = orderGateway.getOrderById(orderId).orElseThrow(NotFoundException::new);
 
-        String qrData = mercadoPagoGateway.generateQRCode(orderDTO.getId(), orderDTO.getTotalPrice());
+        String qrData = mercadoPagoGateway.generateQRCode(orderId, orderDTO.getTotalPrice());
 
-        Payment payment = new Payment(null, false, PaymentStatus.PENDING, PaymentMethod.MERCADO_PAGO_QR_CODE, qrData, orderDTO.getId());
+        Payment payment = new Payment(null, false, PaymentStatus.PENDING, PaymentMethod.MERCADO_PAGO_QR_CODE, qrData, orderId);
 
         paymentGateway.saveAndFlush(payment);
 

src/test/java/br/com/grupo63/techchallenge/payment/PaymentIntegrationTest.java

@@ -48,7 +48,7 @@ class PaymentIntegrationTest {
     private final Long defaultOrderId = 1L;
     private final String qrData = UUID.randomUUID().toString();
     private final Double totalPrice = 100.00;
-    private final OrderDTO orderDTO = new OrderDTO(defaultOrderId, totalPrice);
+    private final OrderDTO orderDTO = new OrderDTO(totalPrice);
     private final Payment payment = new Payment(1L, false, PaymentStatus.PENDING, PaymentMethod.MERCADO_PAGO_QR_CODE, qrData, defaultOrderId);
     private final PaymentPersistenceEntity defaultPaymentPersistenceEntity =
             new PaymentPersistenceEntity(payment);