chore: bump engine.io-parser version

See also: https://github.com/socketio/engine.io-protocol#difference-between-v3-and-v4

Release: https://github.com/socketio/engine.io-parser/releases/tag/4.0.0
Diff: socketio/engine.io-parser@2.2.0...4.0.0

Author: darrachequesne

lib/transports/polling.js

@@ -102,7 +102,7 @@ class Polling extends Transport {
     };
 
     // decode payload
-    parser.decodePayload(data, this.socket.binaryType, callback);
+    parser.decodePayload(data, this.socket.binaryType).forEach(callback);
 
     // if an event did not trigger closing
     if ("closed" !== this.readyState) {
@@ -150,15 +150,13 @@ class Polling extends Transport {
    * @api private
    */
   write(packets) {
-    const self = this;
     this.writable = false;
-    const callbackfn = function() {
-      self.writable = true;
-      self.emit("drain");
-    };
 
-    parser.encodePayload(packets, this.supportsBinary, function(data) {
-      self.doWrite(data, callbackfn);
+    parser.encodePayload(packets, data => {
+      this.doWrite(data, () => {
+        this.writable = true;
+        this.emit("drain");
+      });
     });
   }
 

lib/transports/websocket-constructor.browser.js

@@ -2,5 +2,6 @@ const globalThis = require("../globalThis");
 
 module.exports = {
   WebSocket: globalThis.WebSocket || globalThis.MozWebSocket,
-  usingBrowserWebSocket: true
+  usingBrowserWebSocket: true,
+  defaultBinaryType: "arraybuffer"
 };

lib/transports/websocket-constructor.js

@@ -1,4 +1,5 @@
 module.exports = {
   WebSocket: require("ws"),
-  usingBrowserWebSocket: false
+  usingBrowserWebSocket: false,
+  defaultBinaryType: "nodebuffer"
 };

lib/transports/websocket.js

@@ -3,7 +3,11 @@ const parser = require("engine.io-parser");
 const parseqs = require("parseqs");
 const yeast = require("yeast");
 const { pick } = require("../util");
-const { WebSocket, usingBrowserWebSocket } = require("./websocket-constructor");
+const {
+  WebSocket,
+  usingBrowserWebSocket,
+  defaultBinaryType
+} = require("./websocket-constructor");
 
 const debug = require("debug")("engine.io-client:websocket");
 
@@ -88,16 +92,7 @@ class WS extends Transport {
       return this.emit("error", err);
     }
 
-    if (this.ws.binaryType === undefined) {
-      this.supportsBinary = false;
-    }
-
-    if (this.ws.supports && this.ws.supports.binary) {
-      this.supportsBinary = true;
-      this.ws.binaryType = "nodebuffer";
-    } else {
-      this.ws.binaryType = "arraybuffer";
-    }
+    this.ws.binaryType = this.socket.binaryType || defaultBinaryType;
 
     this.addEventListeners();
   }