Skip to content

Commit a3f2b8c

Browse files
committed
Merge pull request #259 from DevFactory/release/collection-isempty-fix-1
Code Quality Improvement - Collection.isEmpty() should be used to test for emptiness
2 parents 1ef3b2c + d364404 commit a3f2b8c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/main/java/io/socket/client/Manager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ public void call(Object... objects) {
416416

417417
/*package*/ void destroy(Socket socket) {
418418
this.connected.remove(socket);
419-
if (this.connected.size() > 0) return;
419+
if (!this.connected.isEmpty()) return;
420420

421421
this.close();
422422
}
@@ -447,7 +447,7 @@ public void call(Object[] encodedPackets) {
447447
}
448448

449449
private void processPacketQueue() {
450-
if (this.packetBuffer.size() > 0 && !this.encoding) {
450+
if (!this.packetBuffer.isEmpty() && !this.encoding) {
451451
Packet pack = this.packetBuffer.remove(0);
452452
this.packet(pack);
453453
}

src/main/java/io/socket/client/Socket.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ private void onevent(Packet<JSONArray> packet) {
325325
}
326326

327327
if (this.connected) {
328-
if (args.size() == 0) return;
328+
if (args.isEmpty()) return;
329329
String event = args.remove(0).toString();
330330
super.emit(event, args.toArray());
331331
} else {

0 commit comments

Comments
 (0)