fix websocket tests

darrachequesne · darrachequesne · commit 330ab4b9e740 · 2025-12-22T11:41:10.000+01:00
diff --git a/packages/engine.io/test/common.js b/packages/engine.io/test/common.js
@@ -1,5 +1,6 @@
-if (process.env.EIO_CLIENT === "3" && process.versions.node.startsWith("22")) {
-  // FIXME WebSocket error with engine.io-client@3
+if (process.env.EIO_CLIENT === "3") {
+  // we need the WebSocket object provided by the "ws" library to test the SSL certs and HTTP headers so we hide the now built-in WebSocket constructor
+  // ref: https://nodejs.org/api/globals.html#class-websocket
   global.WebSocket = null;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`		`-if (process.env.EIO_CLIENT === "3" && process.versions.node.startsWith("22")) {`
`2`		`- // FIXME WebSocket error with engine.io-client@3`
	`1`	`+if (process.env.EIO_CLIENT === "3") {`
	`2`	`+ // we need the WebSocket object provided by the "ws" library to test the SSL certs and HTTP headers so we hide the now built-in WebSocket constructor`
	`3`	`+ // ref: https://nodejs.org/api/globals.html#class-websocket`
`3`	`4`	`global.WebSocket = null;`
`4`	`5`	`}`
`5`	`6`