Skip to content

Commit b837949

Browse files
ci: use Node.js 24
Reference: https://github.com/nodejs/Release
1 parent 118ef41 commit b837949

File tree

4 files changed

+19
-16
lines changed

4 files changed

+19
-16
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ jobs:
2020
fail-fast: false
2121
matrix:
2222
node-version:
23-
- 18
2423
- 20
2524
- 22
25+
- 24
2626

2727
services:
2828
redis:

package-lock.json

Lines changed: 14 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"tsd": "^0.31.1",
7979
"tsx": "~4.20.6",
8080
"typescript": "^5.5.3",
81-
"uWebSockets.js": "github:uNetworking/uWebSockets.js#v20.48.0",
81+
"uWebSockets.js": "github:uNetworking/uWebSockets.js#v20.56.0",
8282
"wdio-geckodriver-service": "^5.0.2"
8383
}
8484
}

packages/engine.io/test/common.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
if (process.env.EIO_CLIENT === "3" && process.versions.node.startsWith("22")) {
2-
// FIXME WebSocket error with engine.io-client@3
1+
if (process.env.EIO_CLIENT === "3") {
2+
// we need the WebSocket object provided by the "ws" library to test the SSL certs and HTTP headers so we hide the now built-in WebSocket constructor
3+
// ref: https://nodejs.org/api/globals.html#class-websocket
34
global.WebSocket = null;
45
}
56

0 commit comments

Comments
 (0)