Simplify .

Author: samuel-williams-shopify

context/getting-started.md

@@ -109,7 +109,7 @@ require "async/grpc/dispatcher_middleware"
 dispatcher = Async::GRPC::DispatcherMiddleware.new
 
 service = GreeterService.new(GreeterInterface, "hello.Greeter")
-dispatcher.register("hello.Greeter", service)
+dispatcher.register(service)
 ```
 
 ### Running a Server
@@ -152,7 +152,7 @@ Async do
 		# Setup server
 	endpoint = Async::HTTP::Endpoint.parse("http://localhost:50051")
 	dispatcher = Async::GRPC::DispatcherMiddleware.new
-	dispatcher.register("hello.Greeter", GreeterService.new(GreeterInterface, "hello.Greeter"))
+	dispatcher.register(GreeterService.new(GreeterInterface, "hello.Greeter"))
 	server = Async::HTTP::Server.for(endpoint, dispatcher)
 
 		# Setup client

guides/getting-started/readme.md

@@ -109,7 +109,7 @@ require "async/grpc/dispatcher_middleware"
 dispatcher = Async::GRPC::DispatcherMiddleware.new
 
 service = GreeterService.new(GreeterInterface, "hello.Greeter")
-dispatcher.register("hello.Greeter", service)
+dispatcher.register(service)
 ```
 
 ### Running a Server
@@ -152,7 +152,7 @@ Async do
 		# Setup server
 	endpoint = Async::HTTP::Endpoint.parse("http://localhost:50051")
 	dispatcher = Async::GRPC::DispatcherMiddleware.new
-	dispatcher.register("hello.Greeter", GreeterService.new(GreeterInterface, "hello.Greeter"))
+	dispatcher.register(GreeterService.new(GreeterInterface, "hello.Greeter"))
 	server = Async::HTTP::Server.for(endpoint, dispatcher)
 
 		# Setup client

lib/async/grpc/dispatcher_middleware.rb

@@ -22,8 +22,8 @@ module GRPC
 		#
 		# @example Registering services:
 		#   dispatcher = DispatcherMiddleware.new
-		#   dispatcher.register("hello.Greeter", GreeterService.new(GreeterInterface, "hello.Greeter"))
-		#   dispatcher.register("world.Greeter", WorldService.new(WorldInterface, "world.Greeter"))
+		#   dispatcher.register(GreeterService.new(GreeterInterface, "hello.Greeter"))
+		#   dispatcher.register(WorldService.new(WorldInterface, "world.Greeter"))
 		#
 		#   server = Async::HTTP::Server.for(endpoint, dispatcher)
 		class DispatcherMiddleware < Protocol::GRPC::Middleware
@@ -35,12 +35,12 @@ def initialize(app = nil, services: {})
 				@services = services
 			end
 
-			# Register a service.
-			# @parameter service_name [String] Service name (e.g., "hello.Greeter")
-			# @parameter service [Async::GRPC::Service] Service instance
-			def register(service_name, service)
-				@services[service_name] = service
-			end
+		# Register a service.
+		# @parameter service [Async::GRPC::Service] Service instance
+		# @parameter name [String] Service name (defaults to service.service_name)
+		def register(service, name: service.service_name)
+			@services[name] = service
+		end
 
 			protected
 

lib/async/grpc/service.rb

@@ -33,7 +33,7 @@ module GRPC
 		#
 		#   # Register with dispatcher:
 		#   dispatcher = DispatcherMiddleware.new
-		#   dispatcher.register("hello.Greeter", GreeterService.new(GreeterInterface, "hello.Greeter"))
+		#   dispatcher.register(GreeterService.new(GreeterInterface, "hello.Greeter"))
 		#   server = Async::HTTP::Server.for(endpoint, dispatcher)
 		class Service
 			# Initialize a new service instance.

releases.md

@@ -1,5 +1,9 @@
 # Releases
 
+## Unreleased
+
+  - Simplified `DispatcherMiddleware#register` API to `register(service, name: service.service_name)`, eliminating redundant service name specification.
+
 ## v0.2.0
 
   - Added `Async::GRPC::RemoteError` class to encapsulate remote error details including message and backtrace extracted from response headers.

test/async/grpc/dispatcher_middleware.rb

@@ -20,9 +20,16 @@
 	with "#register" do
 		it "can register a service" do
 			dispatcher = subject.new
-			dispatcher.register(service_name, service)
+			dispatcher.register(service)
 			expect(dispatcher.instance_variable_get(:@services)[service_name]).to be == service
 		end
+		
+		it "can register a service with custom name" do
+			dispatcher = subject.new
+			custom_name = "custom.Service"
+			dispatcher.register(service, name: custom_name)
+			expect(dispatcher.instance_variable_get(:@services)[custom_name]).to be == service
+		end
 	end
 
 	with "#call" do