Modernize gem.

ioquatix · ioquatix · commit 83c70427a44b · 2024-10-12T21:22:45.000+13:00
diff --git a/.github/workflows/test-coverage.yaml b/.github/workflows/test-coverage.yaml
@@ -34,8 +34,10 @@ jobs:
       timeout-minutes: 5
       run: bundle exec bake test
     
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
+        include-hidden-files: true
+        if-no-files-found: error
         name: coverage-${{matrix.os}}-${{matrix.ruby}}
         path: .covered.db
   
@@ -50,7 +52,7 @@ jobs:
         ruby-version: "3.3"
         bundler-cache: true
     
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
     
     - name: Validate coverage
       timeout-minutes: 5
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -47,3 +47,7 @@ Layout/EmptyLinesAroundModuleBody:
 
 Style/FrozenStringLiteralComment:
   Enabled: true
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
diff --git a/async-pool.gemspec b/async-pool.gemspec
@@ -10,8 +10,8 @@ Gem::Specification.new do |spec|
 	spec.authors = ["Samuel Williams", "Olle Jonsson", "Simon Perepelitsa", "Thomas Morgan"]
 	spec.license = "MIT"
 	
-	spec.cert_chain  = ['release.cert']
-	spec.signing_key = File.expand_path('~/.gem/release.pem')
+	spec.cert_chain  = ["release.cert"]
+	spec.signing_key = File.expand_path("~/.gem/release.pem")
 	
 	spec.homepage = "https://github.com/socketry/async-pool"
 	
@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
 		"source_code_uri" => "https://github.com/socketry/async-pool.git",
 	}
 	
-	spec.files = Dir.glob(['{lib}/**/*', '*.md'], File::FNM_DOTMATCH, base: __dir__)
+	spec.files = Dir.glob(["{lib}/**/*", "*.md"], File::FNM_DOTMATCH, base: __dir__)
 	
 	spec.required_ruby_version = ">= 3.1"
 	
diff --git a/config/sus.rb b/config/sus.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2022, by Samuel Williams.
+# Copyright, 2022-2024, by Samuel Williams.
 
-require 'covered/sus'
+require "covered/sus"
 include Covered::Sus
diff --git a/examples/memory/gems.rb b/examples/memory/gems.rb
@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2022, by Samuel Williams.
+# Copyright, 2022-2024, by Samuel Williams.
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gem "async"
 gem "async-redis"
diff --git a/examples/overhead/connect.rb b/examples/overhead/connect.rb
@@ -2,12 +2,12 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2021-2022, by Samuel Williams.
+# Copyright, 2021-2024, by Samuel Williams.
 
-require 'async'
+require "async"
 
-require 'async/pool/controller'
-require 'async/pool/resource'
+require "async/pool/controller"
+require "async/pool/resource"
 
 class MyResource < Async::Pool::Resource
 	def self.call
diff --git a/examples/overhead/gems.rb b/examples/overhead/gems.rb
@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2021-2022, by Samuel Williams.
+# Copyright, 2021-2024, by Samuel Williams.
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Takes about ~10s
 # gem "async-pool", "0.3.3"
diff --git a/fixtures/nonblocking_resource.rb b/fixtures/nonblocking_resource.rb
@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2021-2023, by Samuel Williams.
+# Copyright, 2021-2024, by Samuel Williams.
 
-require 'async/pool/controller'
-require 'async/pool/resource'
+require "async/pool/controller"
+require "async/pool/resource"
 
 class Async::Pool::Controller
 	attr :available
diff --git a/gems.rb b/gems.rb
@@ -3,7 +3,7 @@
 # Released under the MIT License.
 # Copyright, 2019-2024, by Samuel Williams.
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec
 
diff --git a/lib/async/pool.rb b/lib/async/pool.rb
@@ -3,8 +3,8 @@
 # Released under the MIT License.
 # Copyright, 2019-2024, by Samuel Williams.
 
-require_relative 'pool/version'
-require_relative 'pool/controller'
+require_relative "pool/version"
+require_relative "pool/controller"
 
 # @namespace
 module Async
diff --git a/lib/async/pool/controller.rb b/lib/async/pool/controller.rb
@@ -5,14 +5,14 @@
 # Copyright, 2020, by Simon Perepelitsa.
 # Copyright, 2024, by Thomas Morgan.
 
-require 'console/logger'
+require "console/logger"
 
-require 'async'
-require 'async/notification'
-require 'async/semaphore'
+require "async"
+require "async/notification"
+require "async/semaphore"
 
-require 'traces'
-require 'metrics'
+require "traces"
+require "metrics"
 
 module Async
 	module Pool
@@ -396,7 +396,7 @@ def create_resource(...)
 						tags: @tags,
 					}
 					
-					Traces.trace('async.pool.create', attributes: attributes) {super}
+					Traces.trace("async.pool.create", attributes: attributes) {super}
 				end
 				
 				def drain(...)
@@ -405,14 +405,14 @@ def drain(...)
 						tags: @tags,
 					}
 					
-					Traces.trace('async.pool.drain', attributes: attributes) {super}
+					Traces.trace("async.pool.drain", attributes: attributes) {super}
 				end
 			end
 			
 			Metrics::Provider(self) do
-				ACQUIRE_COUNT = Metrics.metric('async.pool.acquire', :counter, description: 'Number of times a resource was invoked.')
-				RELEASE_COUNT = Metrics.metric('async.pool.release', :counter, description: 'Number of times a resource was released.')
-				RETIRE_COUNT = Metrics.metric('async.pool.retire', :counter, description: 'Number of times a resource was retired.')
+				ACQUIRE_COUNT = Metrics.metric("async.pool.acquire", :counter, description: "Number of times a resource was invoked.")
+				RELEASE_COUNT = Metrics.metric("async.pool.release", :counter, description: "Number of times a resource was released.")
+				RETIRE_COUNT = Metrics.metric("async.pool.retire", :counter, description: "Number of times a resource was retired.")
 				
 				def acquire(...)
 					ACQUIRE_COUNT.emit(1, tags: @tags)
diff --git a/lib/async/pool/resource.rb b/lib/async/pool/resource.rb
@@ -3,10 +3,10 @@
 # Released under the MIT License.
 # Copyright, 2019-2024, by Samuel Williams.
 
-require 'console/logger'
+require "console/logger"
 
-require 'async/notification'
-require 'async/semaphore'
+require "async/notification"
+require "async/semaphore"
 
 module Async
 	module Pool
diff --git a/test/async/pool.rb b/test/async/pool.rb
@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2022, by Samuel Williams.
+# Copyright, 2022-2024, by Samuel Williams.
 
-require 'async/pool'
+require "async/pool"
 
 describe Async::Pool do
 	it "has a version number" do
diff --git a/test/async/pool/controller.rb b/test/async/pool/controller.rb
diff --git a/test/async/pool/failure.rb b/test/async/pool/failure.rb
diff --git a/test/async/pool/multiplex.rb b/test/async/pool/multiplex.rb
