Log frozen read buffer.

Author: samuel-williams-shopify

lib/io/stream/readable.rb

@@ -187,10 +187,15 @@ def read_until(pattern, offset = 0, limit: nil, chomp: true)
 			if index = index_of(pattern, offset, limit)
 				return nil if limit and index >= limit
 
-				@read_buffer.freeze
+				# @read_buffer.freeze
 				matched = @read_buffer.byteslice(0, index+(chomp ? 0 : pattern.bytesize))
 				@read_buffer = @read_buffer.byteslice(index+pattern.bytesize, @read_buffer.bytesize)
 
+				if @read_buffer.frozen?
+					Console.warn(self, "Read buffer is frozen, duplicating it!", name: "read_until")
+					@read_buffer = @read_buffer.dup
+				end
+				
 				return matched
 			end
 		end
@@ -202,7 +207,7 @@ def read_until(pattern, offset = 0, limit: nil, chomp: true)
 		# @returns [String | Nil] The contents of the stream up until the pattern, or nil if the pattern was not found.
 		def discard_until(pattern, offset = 0, limit: nil)
 			if index = index_of(pattern, offset, limit, true)
-				@read_buffer.freeze
+				# @read_buffer.freeze
 
 				if limit and index >= limit
 					@read_buffer = @read_buffer.byteslice(limit, @read_buffer.bytesize)
@@ -213,6 +218,11 @@ def discard_until(pattern, offset = 0, limit: nil)
 				matched = @read_buffer.byteslice(0, index+pattern.bytesize)
 				@read_buffer = @read_buffer.byteslice(index+pattern.bytesize, @read_buffer.bytesize)
 
+				if @read_buffer.frozen?
+					Console.warn(self, "Read buffer is frozen, duplicating it!", name: "discard_until")
+					@read_buffer = @read_buffer.dup
+				end
+
 				return matched
 			end
 		end
@@ -275,11 +285,16 @@ def gets(separator = $/, limit = nil, chomp: false)
 			end
 
 			# Freeze the read buffer, as this enables us to use byteslice without generating a hidden copy:
-			@read_buffer.freeze
+			# @read_buffer.freeze
 
 			line = @read_buffer.byteslice(0, index+(chomp ? 0 : separator.bytesize))
 			@read_buffer = @read_buffer.byteslice(index+separator.bytesize, @read_buffer.bytesize)
 
+			if @read_buffer.frozen?
+				Console.warn(self, "Read buffer is frozen, duplicating it!", name: "gets")
+				@read_buffer = @read_buffer.dup
+			end
+
 			return line
 		end
 
@@ -343,6 +358,11 @@ def fill_read_buffer(size = @minimum_read_size)
 			# This effectively ties the input and output stream together.
 			flush
 
+			if @read_buffer.frozen?
+				Console.warn(self, "Read buffer is frozen, duplicating it!", name: "fill_read_buffer")
+				@read_buffer = @read_buffer.dup
+			end
+			
 			if @read_buffer.empty?
 				if sysread(size, @read_buffer)
 					# Console.info(self, name: "read") {@read_buffer.inspect}
@@ -392,7 +412,7 @@ def consume_read_buffer(size = nil, buffer = nil)
 			else
 				# We know that we are not going to reuse the original buffer.
 				# But byteslice will generate a hidden copy. So let's freeze it first:
-				@read_buffer.freeze
+				# @read_buffer.freeze
 
 				if buffer
 					# Use replace instead of clear + << for better performance
@@ -401,7 +421,13 @@ def consume_read_buffer(size = nil, buffer = nil)
 				else
 					result = @read_buffer.byteslice(0, size)
 				end
+				
 				@read_buffer = @read_buffer.byteslice(size, @read_buffer.bytesize)
+
+				if @read_buffer.frozen?
+					Console.warn(self, "Read buffer is frozen, duplicating it!", name: "consume_read_buffer")
+					@read_buffer = @read_buffer.dup
+				end
 			end
 
 			return result