Remove ownership model for strings.

Author: ioquatix

benchmark/string.rb

@@ -0,0 +1,38 @@
+
+def generator
+	100000.times do |i|
+		yield "foo #{i}"
+	end
+end
+
+def consumer_without_clear
+	buffer = String.new
+	generator do |chunk|
+		buffer << chunk
+	end
+	return nil
+end
+
+def consumer_with_clear
+	buffer = String.new
+	generator do |chunk|
+		buffer << chunk
+		chunk.clear
+	end
+	return nil
+end
+
+require 'benchmark'
+
+Benchmark.bm do |x|
+	x.report("consumer_with_clear") do
+		consumer_with_clear
+		GC.start
+		
+	end
+	
+	x.report("consumer_without_clear") do
+		consumer_without_clear
+		GC.start
+	end
+end

lib/protocol/http/body/readable.rb

@@ -96,7 +96,6 @@ def join
 
 					self.each do |chunk|
 						buffer << chunk
-						chunk.clear
 					end
 
 					if buffer.empty?

lib/protocol/http/body/rewindable.rb

@@ -54,13 +54,13 @@ def read
 						@index += 1
 					else
 						if chunk = super
-							@chunks << chunk
+							@chunks << -chunk
 							@index += 1
 						end
 					end
 
 					# We dup them on the way out, so that if someone modifies the string, it won't modify the rewindability.
-					return chunk&.dup
+					return chunk
 				end
 
 				def rewind

spec/protocol/http/body/rewindable_spec.rb

@@ -26,18 +26,6 @@
 	let(:source) {Protocol::HTTP::Body::Buffered.new}
 	subject {described_class.new(source)}
 
-	it "doesn't get affected by clearing chunks" do
-		source.write("Hello World!")
-		
-		2.times do
-			chunk = subject.read
-			expect(chunk).to be == "Hello World!"
-			chunk.clear
-			
-			subject.rewind
-		end
-	end
-	
 	it "can write and read data" do
 		3.times do |i|
 			source.write("Hello World #{i}")