Raise an error if singleton headers are set multiple times.

Author: ioquatix

lib/protocol/http/headers.rb

@@ -238,16 +238,21 @@ def []= key, value
 			# The policy for various headers, including how they are merged and normalized.
 			POLICY = {
 				# Headers which may only be specified once:
-				"content-type" => false,
 				"content-disposition" => false,
 				"content-length" => false,
-				"user-agent" => false,
-				"referer" => false,
-				"host" => false,
+				"content-type" => false,
+				"expect" => false,
 				"from" => false,
+				"host" => false,
 				"location" => false,
 				"max-forwards" => false,
+				"range" => false,
+				"referer" => false,
 				"retry-after" => false,
+				"server" => false,
+				"transfer-encoding" => false,
+				"upgrade" => false,
+				"user-agent" => false,
 
 				# Custom headers:
 				"connection" => Header::Connection,
@@ -267,6 +272,7 @@ def []= key, value
 				"etag" => Header::ETag,
 				"if-match" => Header::ETags,
 				"if-none-match" => Header::ETags,
+				"if-range" => false,
 
 				# Headers which may be specified multiple times, but which can't be concatenated:
 				"www-authenticate" => Multiple,
@@ -332,7 +338,10 @@ def delete(key)
 						hash[key] = policy.new(value)
 					end
 				else
-					# We can't merge these, we only expose the last one set.
+					if hash.key?(key)
+						raise ArgumentError, "Duplicate singleton header key: #{key.inspect}"
+					end
+					
 					hash[key] = value
 				end
 			end

test/protocol/http/headers.rb

@@ -42,22 +42,33 @@
 	with "#merge" do
 		it "should merge headers" do
 			other = subject[[
-				# This will replace the original one:
-				["Content-Type", "text/plain"],
-				
 				# This will be appended:
 				["Set-Cookie", "goodbye=world"],
 			]]
 
 			merged = headers.merge(other)
 
 			expect(merged.to_h).to be == {
-				"content-type" => "text/plain",
+				"content-type" => "text/html",
 				"set-cookie" => ["hello=world", "foo=bar", "goodbye=world"],
 				"accept" => ["*/*"],
 				"connection" => ["keep-alive"]
 			}
 		end
+		
+		it "can't merge singleton headers" do
+			other = subject[[
+				["content-type", "text/plain"],
+			]]
+			
+			# This doesn't fail as we haven't built an internal index yet:
+			merged = headers.merge(other)
+			
+			expect do
+				# Once we build the index, it will fail:
+				merged.to_h
+			end.to raise_exception(ArgumentError)
+		end
 	end
 
 	with "#extract" do