Fix tests / documentation.

Author: ioquatix

lib/protocol/http/header/accept.rb

@@ -30,10 +30,16 @@ class Accept < Array
 
 				# A single entry in the Accept: header, which includes a mime type and associated parameters. A media range can include wild cards, but a media type is a specific type and subtype.
 				MediaRange = Struct.new(:type, :subtype, :parameters) do
+					# Create a new media range.
+					#
+					# @parameter type [String] the type of the media range.
+					# @parameter subtype [String] the subtype of the media range.
+					# @parameter parameters [Hash] the parameters associated with the media range.
 					def initialize(type, subtype = "*", parameters = {})
 						super(type, subtype, parameters)
 					end
 
+					# Compare the media range with another media range or a string, based on the quality factor.
 					def <=> other
 						other.quality_factor <=> self.quality_factor
 					end
@@ -46,12 +52,16 @@ def <=> other
 						end.join
 					end
 
+					# The string representation of the media range, including the type, subtype, and any parameters.
 					def to_s
 						"#{type}/#{subtype}#{parameters_string}"
 					end
 
 					alias to_str to_s
 
+					# The quality factor associated with the media range, which is used to determine the order of preference.
+					#
+					# @returns [Float] the quality factor, which defaults to 1.0 if not specified.
 					def quality_factor
 						parameters.fetch("q", 1.0).to_f
 					end

test/protocol/http/header/accept.rb

@@ -11,33 +11,12 @@
 		expect(media_range.quality_factor).to be == 1.0
 	end
 
-	with "#===" do
-		let(:media_range) {subject.new("text", "plain")}
-		
-		it "can compare with bare string" do
-			expect(media_range).to be === "text/plain"
-		end
-		
-		it "can compare with media range" do
-			expect(media_range).to be === media_range
-		end
-	end
-	
 	with "#to_s" do
 		it "can convert to string" do
 			media_range = subject.new("text", "plain", {"q" => "0.5"})
 			expect(media_range.to_s).to be == "text/plain;q=0.5"
 		end
 	end
-	
-	with "#split" do
-		it "can split media range" do
-			media_range = subject.new("text", "plain", {"q" => "0.5"})
-			type, subtype = media_range.split
-			expect(type).to be == "text"
-			expect(subtype).to be == "plain"
-		end
-	end
 end
 
 describe Protocol::HTTP::Header::Accept do
@@ -48,13 +27,23 @@
 		it "can parse media ranges" do
 			expect(header.length).to be == 3
 
-			expect(media_ranges[0].range_string).to be == "text/plain"
-			expect(media_ranges[0].quality_factor).to be == 1.0
-			
-			expect(media_ranges[1].range_string).to be == "text/html"
-			expect(media_ranges[1].quality_factor).to be == 0.5
+			expect(media_ranges[0]).to have_attributes(
+				type: be == "text",
+				subtype: be == "plain",
+				quality_factor: be == 1.0
+			)
 
-			expect(media_ranges[2].range_string).to be == "text/xml"
+			expect(media_ranges[1]).to have_attributes(
+				type: be == "text",
+				subtype: be == "html",
+				quality_factor: be == 0.5
+			)
+				
+			expect(media_ranges[2]).to have_attributes(
+				type: be == "text",
+				subtype: be == "xml",
+				quality_factor: be == 0.25
+			)
 		end
 
 		it "can convert to string" do
@@ -70,20 +59,19 @@
 
 	with "text/html;q=0.25, text/xml;q=0.5, text/plain" do
 		it "should order based on quality factor" do
-			expect(media_ranges.collect(&:range_string)).to be == %w{text/plain text/xml text/html}
+			expect(media_ranges.collect(&:to_s)).to be == %w{text/plain text/xml;q=0.5 text/html;q=0.25}
 		end
 	end
 
 	with "text/html, text/plain;q=0.8, text/xml;q=0.6, application/json" do
 		it "should order based on quality factor" do
-			expect(media_ranges.collect(&:range_string)).to be == %w{text/html application/json text/plain text/xml}
+			expect(media_ranges.collect(&:to_s)).to be == %w{text/html application/json text/plain;q=0.8 text/xml;q=0.6}
 		end
 	end
 
-	with "*/*;q=0" do
+	with "*/*" do
 		it "should accept wildcard media range" do
-			expect(media_ranges[0].range_string).to be == "*/*"
-			expect(media_ranges[0].quality_factor).to be == 0
+			expect(media_ranges[0].to_s).to be == "*/*"
 		end
 	end