Improve test organization.

Author: ioquatix

test/protocol/http/header/digest.rb

@@ -118,33 +118,6 @@
 		end
 	end
 
-	with "Entry class" do
-		let(:entry_class) {subject::Entry}
-		
-		it "can create entry directly" do
-			entry = entry_class.new("sha-256", "abc123")
-			expect(entry.algorithm).to be == "sha-256"
-			expect(entry.value).to be == "abc123"
-			expect(entry.to_s).to be == "sha-256=abc123"
-		end
-		
-		it "normalizes algorithm to lowercase" do
-			entry = entry_class.new("SHA-256", "abc123")
-			expect(entry.algorithm).to be == "sha-256"
-		end
-		
-		it "handles complex algorithm names" do
-			entry = entry_class.new("sha-384", "complex-value")
-			expect(entry.algorithm).to be == "sha-384"
-			expect(entry.to_s).to be == "sha-384=complex-value"
-		end
-		
-		it "handles base64 padding in values" do
-			entry = entry_class.new("md5", "abc123==")
-			expect(entry.value).to be == "abc123=="
-		end
-	end
-	
 	with "algorithm edge cases" do
 		it "handles hyphenated algorithms" do
 			header = subject.new("sha-256=abc123")
@@ -158,7 +131,7 @@
 			expect(entries.first.algorithm).to be == "md5"
 		end
 	end
-	
+
 	with "value edge cases" do
 		it "handles empty values" do
 			header = subject.new("sha-256=")
@@ -172,4 +145,29 @@
 			expect(entries.first.value).to be == "abc+def/123=="
 		end
 	end
-end
+end
+
+describe Protocol::HTTP::Header::Digest::Entry do
+	it "can create entry directly" do
+		entry = subject.new("sha-256", "abc123")
+		expect(entry.algorithm).to be == "sha-256"
+		expect(entry.value).to be == "abc123"
+		expect(entry.to_s).to be == "sha-256=abc123"
+	end
+	
+	it "normalizes algorithm to lowercase" do
+		entry = subject.new("SHA-256", "abc123")
+		expect(entry.algorithm).to be == "sha-256"
+	end
+	
+	it "handles complex algorithm names" do
+		entry = subject.new("sha-384", "complex-value")
+		expect(entry.algorithm).to be == "sha-384"
+		expect(entry.to_s).to be == "sha-384=complex-value"
+	end
+	
+	it "handles base64 padding in values" do
+		entry = subject.new("md5", "abc123==")
+		expect(entry.value).to be == "abc123=="
+	end
+end

test/protocol/http/header/server_timing.rb

@@ -213,39 +213,37 @@
 			expect(metrics.first.duration).to be == 123.456789
 		end
 	end
+end
+
+describe Protocol::HTTP::Header::ServerTiming::Metric do
+	it "can create metric directly" do
+		metric = subject.new("test", 123.45, "Test metric")
+		expect(metric.name).to be == "test"
+		expect(metric.duration).to be == 123.45
+		expect(metric.description).to be == "Test metric"
+		expect(metric.to_s).to be == "test;dur=123.45;desc=\"Test metric\""
+	end
 
-	with "Metric class" do
-		let(:metric_class) {subject::Metric}
-		
-		it "can create metric directly" do
-			metric = metric_class.new("test", 123.45, "Test metric")
-			expect(metric.name).to be == "test"
-			expect(metric.duration).to be == 123.45
-			expect(metric.description).to be == "Test metric"
-			expect(metric.to_s).to be == "test;dur=123.45;desc=\"Test metric\""
-		end
-		
-		it "can create metric with name only" do
-			metric = metric_class.new("cache")
-			expect(metric.name).to be == "cache"
-			expect(metric.duration).to be_nil
-			expect(metric.description).to be_nil
-			expect(metric.to_s).to be == "cache"
-		end
-		
-		it "can create metric with duration only" do
-			metric = metric_class.new("test", 123.45, nil)
-			expect(metric.to_s).to be == "test;dur=123.45"
-		end
-		
-		it "can create metric with description only" do
-			metric = metric_class.new("test", nil, "description")
-			expect(metric.to_s).to be == "test;desc=\"description\""
-		end
-		
-		it "handles nil values correctly" do
-			metric = metric_class.new("test", nil, nil)
-			expect(metric.to_s).to be == "test"
-		end
+	it "can create metric with name only" do
+		metric = subject.new("cache")
+		expect(metric.name).to be == "cache"
+		expect(metric.duration).to be_nil
+		expect(metric.description).to be_nil
+		expect(metric.to_s).to be == "cache"
+	end
+	
+	it "can create metric with duration only" do
+		metric = subject.new("test", 123.45, nil)
+		expect(metric.to_s).to be == "test;dur=123.45"
+	end
+	
+	it "can create metric with description only" do
+		metric = subject.new("test", nil, "description")
+		expect(metric.to_s).to be == "test;desc=\"description\""
+	end
+	
+	it "handles nil values correctly" do
+		metric = subject.new("test", nil, nil)
+		expect(metric.to_s).to be == "test"
 	end
-end
+end

test/protocol/http/header/te.rb

@@ -98,37 +98,37 @@
 		end
 	end
 
-	with "TransferCoding struct" do
-		it "handles quality factor conversion" do
-			coding = Protocol::HTTP::Header::TE::TransferCoding.new("gzip", "0.8")
-			expect(coding.quality_factor).to be == 0.8
-		end
-		
-		it "defaults quality factor to 1.0" do
-			coding = Protocol::HTTP::Header::TE::TransferCoding.new("gzip", nil)
-			expect(coding.quality_factor).to be == 1.0
-		end
-		
-		it "serializes with quality factor" do
-			coding = Protocol::HTTP::Header::TE::TransferCoding.new("gzip", "0.8")
-			expect(coding.to_s).to be == "gzip;q=0.8"
-		end
-		
-		it "serializes without quality factor when 1.0" do
-			coding = Protocol::HTTP::Header::TE::TransferCoding.new("gzip", nil)
-			expect(coding.to_s).to be == "gzip"
-		end
-		
-		it "compares by quality factor" do
-			high = Protocol::HTTP::Header::TE::TransferCoding.new("gzip", "0.9")
-			low = Protocol::HTTP::Header::TE::TransferCoding.new("deflate", "0.5")
-			expect(high <=> low).to be == -1  # high quality first
-		end
-	end
-	
 	with ".trailer?" do
 		it "should be forbidden in trailers" do
 			expect(subject).not.to be(:trailer?)
 		end
 	end
+end
+
+describe Protocol::HTTP::Header::TE::TransferCoding do
+	it "handles quality factor conversion" do
+		coding = subject.new("gzip", "0.8")
+		expect(coding.quality_factor).to be == 0.8
+	end
+	
+	it "defaults quality factor to 1.0" do
+		coding = subject.new("gzip", nil)
+		expect(coding.quality_factor).to be == 1.0
+	end
+	
+	it "serializes with quality factor" do
+		coding = subject.new("gzip", "0.8")
+		expect(coding.to_s).to be == "gzip;q=0.8"
+	end
+	
+	it "serializes without quality factor when 1.0" do
+		coding = subject.new("gzip", nil)
+		expect(coding.to_s).to be == "gzip"
+	end
+	
+	it "compares by quality factor" do
+		high = subject.new("gzip", "0.9")
+		low = subject.new("deflate", "0.5")
+		expect(high <=> low).to be == -1  # high quality first
+	end
 end