Restore default behaviour for with(path:).

Fixes <socketry/cloudflare#75>.

Author: ioquatix

lib/protocol/http/reference.rb

@@ -120,7 +120,7 @@ def base
 			# @argument fragment [String] Set the fragment to this value.
 			# @argument pop [Boolean] If the path contains a trailing filename, pop the last component of the path before appending the new path.
 			# @argument merge [Boolean] If the parameters are specified, merge them with the existing parameters.
-			def with(path: nil, parameters: nil, fragment: @fragment, pop: true, merge: true)
+			def with(path: nil, parameters: nil, fragment: @fragment, pop: false, merge: true)
 				if @parameters
 					if parameters and merge
 						parameters = @parameters.merge(parameters)

test/protocol/http/reference.rb

@@ -50,6 +50,14 @@
 	end
 
 	with '#with' do
+		it "can nest paths" do
+			reference = subject.new('/foo')
+			expect(reference.path).to be == '/foo'
+			
+			nested_resource = reference.with(path: 'bar')
+			expect(nested_resource.path).to be == '/foo/bar'
+		end
+		
 		it "can update path" do
 			copy = reference.with(path: "foo/bar.html")
 			expect(copy.path).to be == "/foo/bar.html"
@@ -113,13 +121,13 @@
 			let(:reference) {subject.new('foo/bar/baz.html', nil, nil, nil)}
 
 			it "can compute new relative path" do
-				copy = reference.with(path: "../index.html")
+				copy = reference.with(path: "../index.html", pop: true)
 
 				expect(copy.path).to be == "foo/index.html"
 			end
 
 			it "can compute relative path with more uplevels" do
-				copy = reference.with(path: "../../../index.html")
+				copy = reference.with(path: "../../../index.html", pop: true)
 
 				expect(copy.path).to be == "../index.html"
 			end