Avoid ZLib::BufError by skipping empty chunks. (#98)

Author: ioquatix

lib/protocol/http/body/deflate.rb

@@ -113,15 +113,19 @@ def read
 					return if @stream.finished?
 
 					# The stream might have been closed while waiting for the chunk to come in.
-					if chunk = super
-						@input_length += chunk.bytesize
-						
-						chunk = @stream.deflate(chunk, Zlib::SYNC_FLUSH)
-						
-						@output_length += chunk.bytesize
-						
-						return chunk
-					elsif !@stream.closed?
+					while chunk = super
+						unless chunk.empty?
+							@input_length += chunk.bytesize
+							
+							chunk = @stream.deflate(chunk, Zlib::SYNC_FLUSH)
+							
+							@output_length += chunk.bytesize
+							
+							return chunk
+						end
+					end
+					
+					if !@stream.closed?
 						chunk = @stream.finish
 
 						@output_length += chunk.bytesize

releases.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
   - Introduce `Protocol::HTTP::Middleware.load` method for loading middleware applications from files.
+  - Prevent `ZLib::BufError` when deflating empty chunks by skipping deflation for empty chunks.
 
 ## v0.58.1
 

test/protocol/http/body/deflate.rb

@@ -72,4 +72,13 @@
 			)
 		end
 	end
+	
+	with "empty chunks" do
+		let(:body) {Protocol::HTTP::Body::Buffered.new(["", "bar", ""])}
+		
+		it "can read empty chunks" do
+			expect(decompressed_body.read).to be == "bar"
+			expect(decompressed_body.read).to be == nil
+		end
+	end
 end