Allow close_read in closed state, as this is idempotent and may be required when closing the response body.

Author: ioquatix

lib/protocol/http1/connection.rb

@@ -214,9 +214,11 @@ def hijack!
 
 			# Close the read end of the connection and transition to the half-closed remote state (or closed if already in the half-closed local state).
 			def close_read
-				@persistent = false
-				@stream&.close_read
-				self.receive_end_stream!
+				unless @state == :closed
+					@persistent = false
+					@stream&.close_read
+					self.receive_end_stream!
+				end
 			end
 
 			# Close the connection and underlying stream and transition to the closed state.

test/protocol/http1/connection.rb

@@ -738,5 +738,39 @@
 			server.close(error)
 			expect(server).to be(:closed?)
 		end
+		
+		it "can close the body before client is closed" do
+			client.open!
+			
+			# Simulate a CONNECT request, which yields a Body::Remainder:
+			server.stream.write("HTTP/1.1 200 Connection Established\r\n\r\n")
+			server.stream.close
+			
+			version, status, reason, headers, body = client.read_response("CONNECT")
+			expect(body).to be_a(Protocol::HTTP1::Body::Remainder)
+			
+			# Close the body before closing the client:
+			body.close
+			
+			# Now, close the client:
+			client.close
+		end
+		
+		it "allows closing remainder body after client is closed" do
+			client.open!
+			
+			# Simulate a CONNECT request, which yields a Body::Remainder:
+			server.stream.write("HTTP/1.1 200 Connection Established\r\n\r\n")
+			server.stream.close
+			
+			version, status, reason, headers, body = client.read_response("CONNECT")
+			expect(body).to be_a(Protocol::HTTP1::Body::Remainder)
+			
+			# Close the client before reading/closing the body:
+			client.close
+			
+			# Now, close the body, which should not raise:
+			body.close
+		end
 	end
 end