Skip to content

Commit ebdc53f

Browse files
committed
Avoid calling @stream.flush as it can block other HTTP/2 streams.
1 parent 1595559 commit ebdc53f

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lib/protocol/http2/framer.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,9 @@ def write_frame(frame)
103103
# Async.logger.debug(self, name: "write") {frame.inspect}
104104

105105
frame.write(@stream)
106-
107-
@stream.flush
106+
107+
# Don't call @stream.flush here because it can cause significant contention if there is a semaphore around this method.
108+
# @stream.flush
108109

109110
return frame
110111
end

0 commit comments

Comments
 (0)