Add support for rack.response_finished to Rack 2.

Author: ioquatix

lib/protocol/rack/adapter/rack2.rb

@@ -116,6 +116,11 @@ def call(request)
 
 					body&.close if body.respond_to?(:close)
 
+					# Rack 2 does not include `rack.response_finished` in the specification. However, if the application has set it, we will call the callbacks here as it would be extremely surprising to not do so.
+					env&.[](RACK_RESPONSE_FINISHED)&.each do |callback|
+						callback.call(env, status, headers, exception)
+					end
+					
 					return failure_response(exception)
 				end
 

releases.md

@@ -1,5 +1,9 @@
 # Releases
 
+## Unreleased
+
+  - Support `rack.response_finished` in Rack 2 if it's present in the environment.
+
 ## v0.16.0
 
   - Hijacked IO is no longer duped, as it's not retained by the original connection, and `SSLSocket` does not support duping.

test/protocol/rack/adapter/rack2.rb

@@ -131,7 +131,6 @@
 			expect(body).to be(:empty?)
 		end
 
-		
 		it "can wrap streaming response" do
 			streaming_body = Protocol::Rack::Body::Streaming.new(->(stream){})
 			response = Protocol::HTTP::Response[200, headers: {}, body: streaming_body]
@@ -145,4 +144,29 @@
 			expect(body).to be == []
 		end
 	end
+	
+	with "response callbacks" do
+		let(:adapter) {subject.new(app)}
+		
+		let(:callback_called) {false}
+		let(:callback) {->(env, status, headers, exception) {@callback_called = true}}
+		let(:app) do
+			proc do |env|
+				env[Protocol::Rack::RACK_RESPONSE_FINISHED] = [callback]
+				raise StandardError.new("Test error")
+			end
+		end
+		let(:request) {Protocol::HTTP::Request["GET", "/", {}, nil]}
+		
+		it "calls response callbacks on failure" do
+			@callback_called = false
+			
+			response = adapter.call(request)
+			
+			expect(@callback_called).to be == true
+			
+			expect(response.status).to be == 500
+			expect(response.read).to be == "StandardError: Test error"
+		end
+	end
 end