Skip to content

Commit 5e776ee

Browse files
Prefer Headers#add over Headers#[]= for adding headers.
1 parent 6cbf133 commit 5e776ee

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

lib/protocol/rack/adapter/rack2.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,10 @@ def wrap_headers(fields)
131131
meta[key] = value
132132
elsif value.is_a?(String)
133133
value.split("\n").each do |value|
134-
headers[key] = value
134+
headers.add(key, value)
135135
end
136136
else
137-
headers[key] = value
137+
headers.add(key, value)
138138
end
139139
end
140140

lib/protocol/rack/adapter/rack3.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ def wrap_headers(fields)
103103
meta[key] = value
104104
elsif value.is_a?(Array)
105105
value.each do |value|
106-
headers[key] = value
106+
headers.add(key, value)
107107
end
108108
else
109-
headers[key] = value
109+
headers.add(key, value)
110110
end
111111
end
112112

releases.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Releases
22

3+
## Unreleased
4+
5+
- Use `Headers#add` instead of `Headers#[]=` in Rack3 and Rack31 adapters, which is the correct interface for appending headers.
6+
37
## v0.18.0
48

59
- Correctly invoke `rack.response_finished` in reverse order.

0 commit comments

Comments
 (0)