Add tests for Rack 3.1 and fix existing tests.

Author: ioquatix

fixtures/protocol/rack/an_adapter.rb

@@ -2,8 +2,11 @@
 # frozen_string_literal: true
 
 require "sus"
+
 require "rack/lint"
+
 require "sus/fixtures/console"
+require "protocol/rack/adapter"
 require "protocol/rack/server_context"
 
 module Protocol

gems/gems.rb

@@ -10,4 +10,5 @@
 gem "bake-test-external"
 gem "sus"
 gem "sus-fixtures-async-http"
+gem "sus-fixtures-console"
 gem "covered"

lib/protocol/rack/adapter/rack3.rb

@@ -57,7 +57,7 @@ def make_environment(request)
 						# I'm not sure what sane defaults should be here:
 						CGI::SERVER_NAME => server_name,
 					}
-
+					
 					# SERVER_PORT is optional but must not be set if it is not present.
 					if server_port
 						env[CGI::SERVER_PORT] = server_port

lib/protocol/rack/adapter/rack31.rb

@@ -48,7 +48,7 @@ def make_environment(request)
 						# I'm not sure what sane defaults should be here:
 						CGI::SERVER_NAME => server_name,
 					}
-
+					
 					# SERVER_PORT is optional but must not be set if it is not present.
 					if server_port
 						env[CGI::SERVER_PORT] = server_port

test/protocol/rack/adapter/rack3.rb

@@ -6,6 +6,7 @@
 require "sus/fixtures/console"
 
 require "protocol/http/request"
+require "protocol/rack/an_adapter"
 require "protocol/rack/adapter/rack3"
 
 describe Protocol::Rack::Adapter::Rack3 do
@@ -45,17 +46,17 @@
 	end
 
 	with "body that responds to #to_path" do
-		let(:body) {Array.new}
-		let(:app) {->(env) {[200, {}, body]}}
+		let(:fake_file) {Array.new}
+		let(:app) {->(env) {[200, {}, fake_file]}}
 
 		it "should generate file body" do
-			expect(body).to receive(:to_path).and_return("/dev/null")
+			expect(fake_file).to receive(:to_path).and_return("/dev/null")
 
 			expect(response.body).to be(:kind_of?, Protocol::HTTP::Body::File)
 		end
 
 		with "206 partial response status" do
-			let(:app) {->(env) {[200, {}, body]}}
+			let(:app) {->(env) {[200, {}, fake_file]}}
 
 			it "should not modify partial responses" do
 				expect(response.body).to be(:kind_of?, Protocol::Rack::Body::Enumerable)

test/protocol/rack/adapter/rack31.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+# Released under the MIT License.
+# Copyright, 2022-2024, by Samuel Williams.
+
+require "sus/fixtures/console"
+
+require "protocol/http/request"
+require "protocol/rack/an_adapter"
+require "protocol/rack/adapter/rack31"
+
+describe Protocol::Rack::Adapter::Rack31 do
+	include Sus::Fixtures::Console::CapturedLogger
+	
+	let(:app) {->(env) {[200, {}, []]}}
+	let(:adapter) {subject.new(app)}
+	
+	let(:body) {Protocol::HTTP::Body::Buffered.new}
+	let(:request) {Protocol::HTTP::Request.new("https", "example.com", "GET", "/", "http/1.1", Protocol::HTTP::Headers[{"accept" => "text/html"}], body)}
+	let(:response) {adapter.call(request)}
+	
+	it_behaves_like Protocol::Rack::AnAdapter
+	
+	with "set-cookie headers that has multiple values" do
+		let(:app) {->(env) {[200, {"set-cookie" => ["a=b", "x=y"]}, []]}}
+		
+		it "can make a response newline separated headers" do
+			expect(response.headers["set-cookie"]).to be == ["a=b", "x=y"]
+		end
+	end
+	
+	with "content-length header" do
+		let(:app) {->(env) {[200, {"content-length" => "10"}, ["1234567890"]]}}
+		
+		it "removes content-length header" do
+			expect(response.headers).not.to be(:include?, "content-length")
+		end
+	end
+	
+	with "connection: close header" do
+		let(:app) {->(env) {[200, {"connection" => "close"}, []]}}
+		
+		it "removes content-length header" do
+			expect(response.headers).not.to be(:include?, "connection")
+		end
+	end
+	
+	with "body that responds to #to_path" do
+		let(:fake_file) {Array.new}
+		let(:app) {->(env) {[200, {}, fake_file]}}
+		
+		it "should generate file body" do
+			expect(fake_file).to receive(:to_path).and_return("/dev/null")
+			
+			expect(response.body).to be(:kind_of?, Protocol::HTTP::Body::File)
+		end
+	
+		with "206 partial response status" do
+			let(:app) {->(env) {[200, {}, fake_file]}}
+			
+			it "should not modify partial responses" do
+				expect(response.body).to be(:kind_of?, Protocol::Rack::Body::Enumerable)
+			end
+		end
+	end
+	
+	with "a request that has response finished callbacks" do
+		let(:callback) {->(env, status, headers, error){}}
+		let(:app) {->(env) {env["rack.response_finished"] << callback; [200, {}, ["Hello World!"]]}}
+		
+		it "should call the callbacks" do
+			expect(callback).to receive(:call)
+			
+			expect(response).to be(:success?)
+			expect(response.read).to be == "Hello World!"
+		end
+	end
+end