Merge pull request brianmario#767 from tamird/deflake-CI

Deflake CI

Author: sodabrew

.travis.yml

@@ -64,11 +64,12 @@ matrix:
       addons:
         hosts:
           - mysql2gem.example.com
-        apt:
-          packages:
-          - mysql-server-5.7
-          - mysql-client-core-5.7
-          - mysql-client-5.7
+        # https://github.com/travis-ci/travis-ci/issues/5122
+        # apt:
+        #   packages:
+        #   - mysql-server-5.7
+        #   - mysql-client-core-5.7
+        #   - mysql-client-5.7
     - rvm: 2.0.0
       env: DB=mysql55
       os: osx

.travis_mysql57.sh

@@ -1,20 +1,12 @@
 #!/usr/bin/env bash
 
-set -eu
-
-service mysql stop
-apt-get purge '^mysql*' 'libmysql*'
-apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 0x8C718D3B5072E1F5
+set -eux
 
+apt-get purge -qq '^mysql*' '^libmysql*'
+apt-key adv --keyserver pgp.mit.edu --recv-keys 5072E1F5
 add-apt-repository 'deb http://repo.mysql.com/apt/ubuntu/ trusty mysql-5.7'
+apt-get update -qq
+apt-get install -qq mysql-server libmysqlclient-dev
 
-apt-get update
-apt-get -o Dpkg::Options::=--force-confdef -o Dpkg::Options::=--force-confnew -y install mysql-server libmysqlclient-dev
-
-mysql_upgrade -u root --force --upgrade-system-tables
-
-# Replace the final line of the mysql apparmor, allowing /etc/mysql/*.pem
-sed -ie '$ s|}|\
-  /etc/mysql/*.pem r,\
-}|' /etc/apparmor.d/usr.sbin.mysqld
-service apparmor restart
+# https://www.percona.com/blog/2016/03/16/change-user-password-in-mysql-5-7-with-plugin-auth_socket/
+mysql -u root -e "ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password BY ''"

.travis_setup.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-set -eu
+set -eux
 
 # Install MySQL 5.7 if DB=mysql57
 if [[ -n ${DB-} && x$DB =~ ^xmysql57 ]]; then
@@ -20,15 +20,12 @@ if ! [[ x$OSTYPE =~ ^xdarwin ]]; then
   sudo service mysql restart
 fi
 
-sudo mysql -u root -e "CREATE USER '$USER'@'localhost'" || true
-sudo mysql -u root -e "GRANT ALL ON test.* TO '$USER'@'localhost'" || true
-
 # Print the MySQL version and create the test DB
 if [[ x$OSTYPE =~ ^xdarwin ]]; then
   $(brew --prefix "$DB")/bin/mysqld --version
-  $(brew --prefix "$DB")/bin/mysql -u $USER -e "CREATE DATABASE IF NOT EXISTS test"
+  $(brew --prefix "$DB")/bin/mysql -u root -e 'CREATE DATABASE IF NOT EXISTS test'
 else
   mysqld --version
   # IF NOT EXISTS is mariadb-10+ only - https://mariadb.com/kb/en/mariadb/comment-syntax/
-  mysql -u $USER -e "CREATE DATABASE /*M!50701 IF NOT EXISTS */ test"
+  mysql -u root -e 'CREATE DATABASE /*M!50701 IF NOT EXISTS */ test'
 fi

.travis_ssl.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-set -eu
+set -eux
 
 # Make sure there is an /etc/mysql
 mkdir -p /etc/mysql

Rakefile

@@ -8,13 +8,13 @@ load 'tasks/compile.rake'
 load 'tasks/generate.rake'
 load 'tasks/benchmarks.rake'
 
-# TODO: remove when we end support for < 1.9.3
-begin
+# TODO: remove engine check when rubinius stops crashing on RuboCop
+# TODO: remove defined?(Encoding) when we end support for < 1.9.3
+if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'ruby' && defined?(Encoding)
   require 'rubocop/rake_task'
   RuboCop::RakeTask.new
   task :default => [:spec, :rubocop]
-
-rescue LoadError
+else
   warn 'RuboCop is not available'
   task :default => :spec
 end

spec/configuration.yml.example

@@ -9,9 +9,3 @@ user:
   username: LOCALUSERNAME
   password:
   database: mysql2_test
-
-numericuser:
-  host: localhost
-  username: LOCALUSERNAME
-  password:
-  database: 12345

spec/mysql2/client_spec.rb

@@ -263,13 +263,14 @@ def run_gc
   end
 
   it "should be able to connect to database with numeric-only name" do
-    creds = DatabaseCredentials['numericuser']
-    @client.query "CREATE DATABASE IF NOT EXISTS `#{creds['database']}`"
-    @client.query "GRANT ALL ON `#{creds['database']}`.* TO #{creds['username']}@`#{creds['host']}`"
+    database = 1235
+    @client.query "CREATE DATABASE IF NOT EXISTS `#{database}`"
 
-    expect { Mysql2::Client.new(creds) }.not_to raise_error
+    expect {
+      Mysql2::Client.new(DatabaseCredentials['root'].merge('database' => database))
+    }.not_to raise_error
 
-    @client.query "DROP DATABASE IF EXISTS `#{creds['database']}`"
+    @client.query "DROP DATABASE IF EXISTS `#{database}`"
   end
 
   it "should respond to #close" do

spec/mysql2/statement_spec.rb

@@ -6,11 +6,13 @@
     @client = Mysql2::Client.new(DatabaseCredentials['root'].merge(:encoding => "utf8"))
   end
 
+  def stmt_count
+    @client.query("SHOW STATUS LIKE 'Prepared_stmt_count'").first['Value'].to_i
+  end
+
   it "should create a statement" do
     statement = nil
-    expect { statement = @client.prepare 'SELECT 1' }.to change {
-      @client.query("SHOW STATUS LIKE 'Prepared_stmt_count'").first['Value'].to_i
-    }.by(1)
+    expect { statement = @client.prepare 'SELECT 1' }.to change(&method(:stmt_count)).by(1)
     expect(statement).to be_an_instance_of(Mysql2::Statement)
   end
 
@@ -689,9 +691,7 @@
   context 'close' do
     it 'should free server resources' do
       stmt = @client.prepare 'SELECT 1'
-      expect { stmt.close }.to change {
-        @client.query("SHOW STATUS LIKE 'Prepared_stmt_count'").first['Value'].to_i
-      }.by(-1)
+      expect { stmt.close }.to change(&method(:stmt_count)).by(-1)
     end
 
     it 'should raise an error on subsequent execution' do

spec/ssl/gen_certs.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-set -eu
+set -eux
 
 echo "
 [ ca ]