remove distutils in order to support python 3.12 #2439
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vebjorre
changed the title
paulteehan
requested changes
Nov 25, 2025
| def strtobool(val: str) -> bool: | ||
| return val.lower() in ("yes", "y", "true", "t", "1") | ||
|
|
||
|
|
There was a problem hiding this comment.
Hello @vebjorre , thanks very much for this contribution! We'd like to request two small edits after which we'd be happy to merge and release this.
- It looks like
"on"should be in the tuple - The original
strtoboolimplementation throws a ValueError if you pass in an invalid value, we'd like to keep that behavior
If you could make those edits then we'll move this forward, thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing the work of @akx in #2144, removing any use of distutils in order to support python>=3.12.
Fixes #2091